search

sos-os / alarm

ALARM: Another Library for Allocating and Releasing Memory
Apache License 2.0
8 stars 6 forks source link

feat(singly): UnsafeRef impl #44

Closed amanjeev closed 6 years ago

amanjeev commented 6 years ago

resolves https://github.com/sos-os/alarm/issues/37

amanjeev commented 6 years ago

I actually think some naming is bad in this one, esp. extend.

amanjeev commented 6 years ago

Why isn't travis build running for this PR. 🤔

hawkw commented 6 years ago

@amanjeev I suspect the GitHub/Travis webhooks integration got messed up somehow when I moved the repo to the sos-os organization; I'll look at the settings and see if I can figure that out.

hawkw commented 6 years ago

Okay, I went into the repo settings and sent Travis a test webhook; that seems to have gotten it unstuck and it looks like your build has passed! ✅

hawkw commented 6 years ago

@amanjeev

I actually think some naming is bad in this one, esp. extend.

I'm not sure which naming you mean here --- if you're saying that the name of the extend method isn't ideal for a stack, that's a fair point, but since Extend is a standard-library trait that we're implementing here, we can't change the name of the method.

amanjeev commented 6 years ago

if you're saying that the name of the extend method isn't ideal for a stack

That's what I meant but thanks for correcting me.