search

soscripted / sox

Stack Overflow Extras: a userscript for the Stack Exchange websites to add a bunch of optional toggle-able features
http://stackapps.com/q/6091/
MIT License
72 stars 15 forks source link

Fixed topbar feature messes with sites with designs at the top #146

Closed Sir-Cumference closed 7 years ago

Sir-Cumference commented 7 years ago

If you go to worldbuilding.stackexchange.com, you'll probably see the the image on the bottom of the page overlapping the image on the top of the page.

screen shot 2016-11-15 at 1 39 59 am

This happens on any page, including meta pages. Disabling SOX entirely fixes the problem.

Features Enabled

["Appearance-addAuthorNameToInboxNotifications","Appearance-answerTagsSearch","Appearance-betterCSS","Appearance-dragBounty","Appearance-fixedTopbar","Appearance-grayOutVotes","Appearance-hideHireMe","Appearance-metaChatBlogStackExchangeButton","Appearance-metaNewQuestionAlert","Appearance-spoilerTip","Appearance-standOutDupeCloseMigrated","Appearance-unspoil","Appearance-disableOwnPostVoteButtons","Comments-commentReplies","Comments-commentShortcuts","Comments-showCommentScores","Flags-flagOutcomeTime","Flags-flagPercentages","Unsorted-downvotedPostsEditAlert","Unsorted-parseCrossSiteLinks","Unsorted-replyToOwnChatMessages"]
shu8 commented 7 years ago

I'm beginning to hate the fixed topbar feature... 😢

I'll look at this on the weekend, because I don't think I'll have any time this week :(

shu8 commented 7 years ago

@IStoleThePies Fixed in latest dev t

But, this will almost definitely have broken it on another site, because I got rid of a CSS rule which I can't remember why it was there, so if you notice being weird on any other site, please comment back here! :)

Sir-Cumference commented 7 years ago

@shu8 Also strangely, the logo and upper parts of the Worldbuilding site seem to jump up after SOX loads.

shu8 commented 7 years ago

Yeah I just noticed that after I pushed it. I'll try fix it by the next version

On 19 Nov 2016 7:05 p.m., "IStoleThePies" notifications@github.com wrote:

@shu8 https://github.com/shu8 Also strangely, the logo and upper parts of the Worldbuilding site seem to jump up after SOX loads.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/soscripted/sox/issues/146#issuecomment-261732904, or mute the thread https://github.com/notifications/unsubscribe-auth/AIcNjhRSDufpOtdHdzPE4Dv3hgHtVPthks5q_0hogaJpZM4KzAEt .

shu8 commented 7 years ago

@IStoleThePies Seems like a complicated issue, and I'm really bad with CSS -- @enki-code's the expert in that :P So I think we'll need to wait for him to be back to get this one fixed :(

Sorry!

Sir-Cumference commented 7 years ago

@shu8 Yeah, also just realized it happens with lots of sites. In beta sites it cuts off the blue part of the header.

shu8 commented 7 years ago

@IStoleThePies @enki-code had a look at it and worked out a fix. Done in dev v