Closed fixer1234 closed 7 years ago
shu8
commented
7 years ago @fixer1234 you're exactly right; it doesn't work for sites that aren't on the same site because of the Same Origin Policy (you're not allowed to access any post that's not part of the same domain, inc, subdomains). So it was previously getting the text for the post ID 5329 on SU rather than MSU :/
I've changed it so that it takes this into account now in dev aa
fixer1234
commented
7 years ago @shu8 Looks like you've disabled the arrow on non-local links. Another success.
fixer1234
commented
7 years ago @shu8 Strange. Just went back to a recent comment (canned comment with a bunch of Meta site help links). The arrows appeared on those. SSL connection on Java 7 based server fails with RECV TLSv1 ALERT: fatal, handshake_failure
shu8
commented
7 years ago they're not meta links, but that is another bug -- I need to make sure the link is to a question as well.
working on it now
On 2 January 2017 at 22:25, fixer1234 notifications@github.com wrote:
@shu8 https://github.com/shu8 Strange. Just went back to a recent comment (canned comment with a bunch of Meta site help links). The arrows appeared on those. SSL connection on Java 7 based server fails with RECV TLSv1 ALERT: fatal, handshake_failure http://superuser.com/a/1162676/364367
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/soscripted/sox/issues/205#issuecomment-270026695, or mute the thread https://github.com/notifications/unsubscribe-auth/AIcNjgEqQ9E5O9hvguSzwsp9R7vEwlPNks5rOXlEgaJpZM4LY1gl .
fixer1234
commented
7 years ago @shu8 Confirmed. Both question and answer links have arrows, but only for the local site.
Installed Version: 2.0.2 Environment: FF/GM
Current Behaviour
Had to go back to v2.0.2 official because the hanging problem made 2.0.3 Dev impractical.
Went back to an earlier comment and noticed that it contained a link with the display inline arrow. So I used the opportunity to do a random test on it. The link was to our canonical Meta post on software recommendations (http://meta.superuser.com/questions/5329/how-do-i-recommend-software-in-my-answers). The display arrow found some random text from somewhere (and it was nothing I had visited, so it wasn't a cached snippet; in fact, a search didn't find that text anywhere).
SOX Errors logged to the browser console -- F12 (if available)
The above was produced refreshing the page. Below was generated when I clicked the display arrow (and it retrieved the same strange snippet, again).
The last snippet includes a reference to http://superuser.com/posts/5329/body. Opening that URL produces the strange text shown. Removing "body" from the URL links to "page not found". I might have missed it, but I didn't see the correct link referenced in the output.
I spotted this line in the console output:
SOX: There was an error loading the feature "Editing-inlineEditorEverywhere". Please raise an issue on GitHub, and copy the following error log: ReferenceError: StackExchange is not defined
but I think that's a different feature. So just FYI. There were also a bunch of "can't access dead object" errors at the beginning.
Update: Just tried several more examples in comments. The arrow rotated down, but nothing was displayed. For example: What is the cause of a horizontal white line on an LCD monitor?
However, in this thread and a few others, there were several links in comments that worked correctly: White line on LCD. A link I found in an answer post also worked correctly.
Links to Meta posts seem to fail. The working links were to SU posts. Maybe the feature works only within the same site, but also displays the arrows on links it can't handle?
Steps to reproduce