search

soscripted / sox

Stack Overflow Extras: a userscript for the Stack Exchange websites to add a bunch of optional toggle-able features
http://stackapps.com/q/6091/
MIT License
72 stars 15 forks source link

Should we drop support for the old topbar? #349

Closed Sir-Cumference closed 6 years ago

Sir-Cumference commented 6 years ago

Pretty much every site uses the new topbar. Server Fault and SO are a bit different, but they still have the same topbar class as the other sites.

Right now, SOX is pretty broken on sites with the old topbar, e.g. Area 51 and chatroom pages, and those sites are becoming a bit of a hassle to keep up with considering SOX isn't very useful there. We'd also probably clear up a lot of code if we removed the if statements that check whether the topbar is the new one or old one.

What do you think?

EDIT: Just noticed SE implemented a vanilla sticky topbar: https://meta.stackexchange.com/questions/311213/can-i-please-have-the-option-to-sticky-my-top-bar-wherever-i-want?noredirect=1&lq=1

shu8 commented 6 years ago

@Sir-Cumference Yes! I thought this too once I saw the New global preferences: keyboard shortcuts and sticky topbar post!

Funnily enough, they're having some of the same problems we did with SOX trying to implement it 😆

shu8 commented 6 years ago

I think we should also remove the fixed topbar feature as well as they support it natively now?

Sir-Cumference commented 6 years ago

@shu8 Sounds good, or we could at least change it to "Add fixed topbar on Ask Ubuntu".

shu8 commented 6 years ago

Perfect, and once the redesign is done we can get rid of it altogether :)

shu8 commented 6 years ago

I've just pushed an update to remove the fixedTopbar feature because Ask Ubuntu's site design has now been updated so the feature is natively supported!

As far as I can see, we have dropped support for it now, but I may have missed an area -- if you spot something please comment here!