soscripted / sox

Stack Overflow Extras: a userscript for the Stack Exchange websites to add a bunch of optional toggle-able features
http://stackapps.com/q/6091/
MIT License
72 stars 15 forks source link

"HTTP-Based Public Key Pinning is deprecated" warning for isQuestionHot #353

Closed GaurangTandon closed 6 years ago

GaurangTandon commented 6 years ago

image

HTTP-Based Public Key Pinning is deprecated. Chrome 69 and later will ignore HPKP response headers. (Host: query.yahooapis.com)

On the line:

if (sox.location.on('/questions') || $('.question-summary').length) {
    $.ajax({

I am not sure how to fix it :/

Considering I'm on version 67 already, I think you need to act fact on this one!

shu8 commented 6 years ago

Thanks. I'll look into it.

I also need to change showMetaReviewCount as the yahoo YQL service it uses not longer works for HTML. If I do that, I might just stop using it altogether if I find an alternative like the crossorigin.me site.

j-f1 commented 6 years ago

That doesn’t seem like a big issue. HPKP is basically the server telling the browser to only accept a certain certificate when connecting to that sever via HTTPS. Since Chrome will ignore the header, everything will work OK.

shu8 commented 6 years ago

@j-f1 Thanks! I've still removed the YQL use though because it seems like they've changed it a few times recently and it's probably going to break soon anyway 😆

GaurangTandon commented 6 years ago

@j-f1 Ah, so it's an issue from query.yahooapis.com's side and not from ours?

j-f1 commented 6 years ago

Yep! That’s correct.