search

soscripted / sox

Stack Overflow Extras: a userscript for the Stack Exchange websites to add a bunch of optional toggle-able features
http://stackapps.com/q/6091/
MIT License
72 stars 15 forks source link

Checkbox for "Add Scroll To Top button" seems amiss #366

Closed IzzySoft closed 5 years ago

IzzySoft commented 5 years ago

Installed Version:

2.3.8 DEV Environment: undefined

Current Behaviour

Looks line the check box for "Add Scroll To Top button" has disappeared:

screenshot

That makes it impossible to switch this feature off. Not that I want to, but others might :wink:

SOX Errors logged to the browser console -- F12 (if available)

unlikely to be relevant, the only line I found:

SOX:  inlineEditorEverywhere error: sox.Stack.using not found

Steps to reproduce

Just click the icon in the MetaCollider™ to open SOX settings.

Features Enabled

Again subject to change, just started going through the settings one by one:

["Appearance-alignBadgesByClass","Appearance-colorAnswerer","Appearance-displayName","Appearance-dragBounty","Appearance-highlightQuestions","Appearance-isQuestionHot","Appearance-localTimestamps","Appearance-metaChatBlogStackExchangeButton","Appearance-scrollToTop","Appearance-spoilerTip","Appearance-tabularReviewerStats","Appearance-topAnswers","Appearance-unspoil","Appearance-addTimelineAndRevisionLinks","Appearance-showTagWikiLinkOnTagPopup","Comments-autoShowCommentImages","Comments-commentReplies","Comments-commentShortcuts","Comments-confirmNavigateAway","Comments-copyCommentsLink","Comments-moveBounty","Comments-hiddenCommentsIndicator","Comments-onlyShowCommentActionsOnHover","Editing-addSBSBtn","Editing-editComment","Editing-editReasonTooltip","Editing-findAndReplace","Editing-kbdAndBullets","Editing-titleEditDiff","Editing-inlineEditorEverywhere","Editing-pasteImagesDirectly","Flags-flagOutcomeTime","Flags-flagPercentages","Flags-flagPercentageBar","Sidebar-hideCommunityBulletin","Sidebar-hideJustHotMetaPosts","Sidebar-hideHireMe","Sidebar-hideChatSidebar","Sidebar-hideLoveThisSite","Sidebar-hideHotNetworkQuestions","Sidebar-linkedToFrom","Chat-chatEasyAccess","Chat-replyToOwnChatMessages","Chat-renameChat","Voting-betterCSS","Voting-stickyVoteButtons","Voting-disableVoteButtons","Extras-alwaysShowImageUploadLinkBox","Extras-linkedPostsInline","Extras-shareLinksPrivacy","Extras-shareLinksMarkdown","Extras-sortByBountyAmount","Extras-warnNotLoggedIn","Extras-hideCertainQuestions","Extras-showMetaReviewCount","Extras-copyCode","Extras-dailyReviewBar","Extras-openLinksInNewTab"]
shu8 commented 5 years ago

Thanks for the bug report, I'll try looking into it soon!

The console error you got seems like another separate bug but I will look into that too!

On Fri, 28 Sep 2018, 22:42 Izzy, notifications@github.com wrote:

Installed Version:

2.3.8 DEV Environment: undefined Current Behaviour

Looks line the check box for "Add Scroll To Top button" has disappeared:

[image: screenshot] https://i.stack.imgur.com/18DGe.png

That makes it impossible to switch this feature off. Not that I want to, but others might 😉

SOX Errors logged to the browser console -- F12 (if available)

unlikely to be relevant, the only line I found:

SOX: inlineEditorEverywhere error: sox.Stack.using not found

Steps to reproduce

Just click the icon in the MetaCollider™ to open SOX settings.

Features Enabled

Again subject to change, just started going through the settings one by one:

["Appearance-alignBadgesByClass","Appearance-colorAnswerer","Appearance-displayName","Appearance-dragBounty","Appearance-highlightQuestions","Appearance-isQuestionHot","Appearance-localTimestamps","Appearance-metaChatBlogStackExchangeButton","Appearance-scrollToTop","Appearance-spoilerTip","Appearance-tabularReviewerStats","Appearance-topAnswers","Appearance-unspoil","Appearance-addTimelineAndRevisionLinks","Appearance-showTagWikiLinkOnTagPopup","Comments-autoShowCommentImages","Comments-commentReplies","Comments-commentShortcuts","Comments-confirmNavigateAway","Comments-copyCommentsLink","Comments-moveBounty","Comments-hiddenCommentsIndicator","Comments-onlyShowCommentActionsOnHover","Editing-addSBSBtn","Editing-editComment","Editing-editReasonTooltip","Editing-findAndReplace","Editing-kbdAndBullets","Editing-titleEditDiff","Editing-inlineEditorEverywhere","Editing-pasteImagesDirectly","Flags-flagOutcomeTime","Flags-flagPercentages","Flags-flagPercentageBar","Sidebar-hideCommunityBulletin","Sidebar-hideJustHotMetaPosts","Sidebar-hideHireMe","Sidebar-hideChatSidebar","Sidebar-hideLoveThisSite","Sidebar-hideHotNetworkQuestions","Sidebar-linkedToFrom","Chat-chatEasyAccess","Chat-replyToOwnChatMessages","Chat-renameChat","Voting-betterCSS","Voting-stickyVoteButtons","Voting-disableVoteButtons","Extras-alwaysShowImageUploadLinkBox","Extras-linkedPostsInline","Extras-shareLinksPrivacy","Extras-shareLinksMarkdown","Extras-sortByBountyAmount","Extras-warnNotLoggedIn","Extras-hideCertainQuestions","Extras-showMetaReviewCount","Extras-copyCode","Extras-dailyReviewBar","Extras-openLinksInNewTab"]

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/soscripted/sox/issues/366, or mute the thread https://github.com/notifications/unsubscribe-auth/AIcNjixX4XKU7I8WRt8ZuPrPEJF8FOfEks5ufpeugaJpZM4W_907 .

shu8 commented 5 years ago

@IzzySoft Please could you right click on the add scroll to top button and click 'inspect element' and screenshot what comes up? I can't reproduce it :/

IzzySoft commented 5 years ago

Yes, I can:

HTML

Looks like the checkbox is hidden. So, one more screenshot:

HTML with CSS

See: display: none !important. If that wasn't you, it must collide with some other UserScript or UserStyle. Though the name of the rule looks weird. Clicking on the rule points to "inline stylesheet", with a bunch of rules from SOUP again – but I couldn't find that rule there. Couldn't even make it show by overriding CSS on the element itself (display:block visibility:visible, both with !important) – which seems very strange. Disabled SOUP and reloaded – no change. Disabled all other UserScripts – nada. Disabled all UserStyles – niente. Out of ideas what I could try from my end now.

shu8 commented 5 years ago

@IzzySoft Thanks for the thorough debugging! I can't understand what's happening here 😆 Does this happen on a specific site, or is the checkbox hidden in all of them?

Please could you paste the entire block of styles that clicking the weird rule takes you to? I could try seeing if there's any SOX rule within there!

shu8 commented 5 years ago

@IzzySoft Also, for the other error you got, just underneath it there should be a inlineEditorEverywhere: Stack object: followed by another line of the object -- could you paste that here too please? :)

IzzySoft commented 5 years ago

Does this happen on a specific site, or is the checkbox hidden in all of them?

All I've checked. Need to check at work on Monday if the issue is present there as well; I vaguely remember it is not, and the difference would be the token being present there.

Please could you paste the entire block of styles that clicking the weird rule takes you to?

Sure: https://pastebin.com/i1Eht1Mv (was too fooking long; what the heck is that long list of URLs there?)

just underneath it there should be a inlineEditorEverywhere: Stack object: …

Afraid not:

SOX:  inlineEditorEverywhere error: sox.Stack.using not found    sox.common.js:32:13
soup JS fixes applied

No more SOX after that. Just a new one before that:

SOX:  There was an error loading the feature "Appearance-colorAnswerer". Please raise an issue on GitHub, and copy the following error log:
TypeError: this.querySelector(...) is null   sox.common.js:38:13

Ugh. Another issue to open?

PS: Why are the buttons "Close and comment" and "Comment" just inverted compared to GitLab? Guess that's why you see close/reopen so often within a single minute … Almost happened to me now :rofl:

shu8 commented 5 years ago

@IzzySoft Thanks! Those CSS rules really are weird! :/ It seems like it's hiding all social links and buttons and buttons like 'back to top', 'scroll to top' along with it. Do you have any extensions other than uBlock origin installed that hide 'social' buttons?

I think the 2nd debug line only comes if debugging is enabled -- could you check it is still enabled please?

Don't worry about opening another issue, I'll make sure I look into that too! Which page were you on when it happened?

I've never used gitlab so I didn't know that! Although, I don't remember seeing many close/reopens myself!

IzzySoft commented 5 years ago

Do you have any extensions other than uBlock origin installed that hide 'social' buttons?

None that I'm aware of (just went through the list again). Only one CSS, but that's not active on SE sites (deactivated it nevertheless, no effect). But even if, I find it very strange that I can't even override that on the object itself (style="display:block …"). But true enough: as soon as I change the ID, the check box shows up. Sufficient to just add a letter to the end, like "ScrollToTopp".

I think the 2nd debug line only comes if debugging is enabled -- could you check it is still enabled please?

As the link at the end of settings say "Enable Debugging", I'd say it's not active. Wait: on that page the error is not present in console. I only seem to have that on Android.SE (link says the same there). Just verified here: https://android.stackexchange.com/q/29447/16575

Not from SOX, but I love this kind of lines:

Loading failed for the <script> with source “https://www.google-analytics.com/analytics.js”.
IzzySoft commented 5 years ago

PS: Just disabled the mega-block in "inspect element". A few seconds later the check box showed up. So at least it's clear now which rule is responsible. Remains the question who establishes it.

Looks like it is uBlock Origin. I just grepped my entire FF profile for "hero-content" (first line of that mega rule). Only place it appears is in uBlock's SQLite database. And guess what, "ScrollToTop" is in there as well. OK, need to write down what rule sets I've included here and verify that with what I have at work … nope, not needed: "Fanboy’s Annoyance List" includes "#ScrollToTop". Checking: Disabled that list, Checkbox appears.

shu8 commented 5 years ago

@IzzySoft Nice! it's an interesting way it uses to hide it! Glad it's sorted though :)

Just to clarify -- is it the inlineEditorEverywhere error only happens on Android? If so, could you check SR too, as it may be to do with you being a mod there?

IzzySoft commented 5 years ago

Got that inlineEditorEverywhere error also on SR, e.g. here: https://softwarerecs.stackexchange.com/q/52574/185

As for that check-box: If I need it I now know how to get to it. Still arguing with myself whether to disable that Fanboy list or not: this might be the first culprit I encountered, who knows if there are more. It's a bit crazy to block a simple ID like this without leaving a chance to counter that (I tried and failed). Checking what that list holds feels like 50:50 (half of it is useful, the other half crazy). Guess I kick it altogether.

shu8 commented 5 years ago

@IzzySoft the inline editor everywhere issue should be fixed in the latest dev version :)

That check box thing is pretty annoying! If you could just edit the list and remove the go to top selector that would be the best because it's a pretty common button that can be useful sometimes!

IzzySoft commented 5 years ago

Thanks! That error was replaced now by

There was an error loading the feature "Editing-inlineEditorEverywhere". Please raise an issue on GitHub, and copy the following error log:

TypeError: sox.Stack.using is not a function

:scream:

And why the heck does the preview suddenly not work here at Github? Strange …

Editing that list won't do any good, as the rule would be back at the next update. A "counter rule" should work, or removing that list. Not urgent for me, though, so don't invest too much time in it :wink:

shu8 commented 5 years ago

Great 😂 I'll try getting it fixed this weekend!

I think the preview was working for me yesterday! Must just be a temporary bug!

On Mon, 5 Nov 2018, 14:42 Izzy <notifications@github.com wrote:

Thanks! That error was replaced now by

There was an error loading the feature "Editing-inlineEditorEverywhere". Please raise an issue on GitHub, and copy the following error log:

TypeError: sox.Stack.using is not a function

😱

And why the heck does the preview suddenly not work here at Github? Strange …

Editing that list won't do any good, as the rule would be back at the next update. A "counter rule" should work, or removing that list. Not urgent for me, though, so don't invest too much time in it 😉

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/soscripted/sox/issues/366#issuecomment-435898995, or mute the thread https://github.com/notifications/unsubscribe-auth/AIcNjm797208MmS19wCVtB9OB168zetzks5usE44gaJpZM4W_907 .

IzzySoft commented 5 years ago

Take your time – I just found this checking the console, so it doesn't seem really urgent :wink:

As for the preview: it's broken for me on my second machine as well. If it's currently broken for you, too, I'll just wait and see tomorrow. A quick search didn't show anything, Github status says "all green".

shu8 commented 5 years ago

@IzzySoft I can't reproduce it :/ Which browser are you on again? (sorry, I keep forgetting!)

The preview was working for me! Is it working now?

IzzySoft commented 5 years ago

No, and neither is edit and opening pull requests (in case I caused confusion: I'm talking about Github here, not about SOX). And I use Firefox/Waterfox.