soscripted / sox

Stack Overflow Extras: a userscript for the Stack Exchange websites to add a bunch of optional toggle-able features
http://stackapps.com/q/6091/
MIT License
72 stars 15 forks source link

The View/Remove Edit Reasons box needs change. #377

Closed Nc432o5 closed 5 years ago

Nc432o5 commented 5 years ago

A few things:

No margin between the delete button and the text.

Just see for yourself: bad stuff Can you add a margin-right/-left?

No edit button.

Please add a button to the left of the delete one to edit it.

No way to reorder.

Can not change the order in which options appear without deleting all of them and reading in a different order. Can you make a drag & drop interface or up and down buttons?

Needes two more default reasons: title & retag.

Make the delete button red, not blue.

If the edit button is added, that one should still be blue.

The window opens by default position blocked by the top bar.

See the image. noooooooo!

shu8 commented 5 years ago

Thanks, revamping that modal's UI is on my todo list, to make it look like SE's modals. See the custom magic links feature's modal for an idea of how it will soon look!

Thanks for the other suggestions on functionality, I'll see what I can do about them :)

shu8 commented 5 years ago

@Ethan-JK I've done all the design change in dev 2.3.27. I didn't get round to the edit/reorder functionality (it's slightly more involved than design changes!) so will try getting that done at a later date.

Looking at the SOX code, a lot of features' code can be improved, so I may rewrite this entirely instead!

Please let me know if the design changes are what you were thinking of!

Nc432o5 commented 5 years ago

@shu8 Wow! Thank looks really good!

One thing: The delete button is a little too bold. Could you make the button less bold or the text next to it bolder?

shu8 commented 5 years ago

Sure, I'll get that done soon :)

shu8 commented 5 years ago

@Ethan-JK How's the delete button now in dev 2.3.29?

Nc432o5 commented 5 years ago

@shu8 Nice! I was kind of thinking of something plain like this:

so edit custon reasons

With the delete button being the same as the discard button for a question/answer.

shu8 commented 5 years ago

@Ethan-JK Thanks for the mockup!

How's it now in dev 2.3.30?

I've also added the edit option :)

image

Nc432o5 commented 5 years ago

@shu8 Cool! That looks and works great! One thing - are there any plans to move around the order of the reasons?

Other than that, this looks awesome!

shu8 commented 5 years ago

@Ethan-JK glad you like it!

To be honest, I'm not sure how useful people would find re-ordering the reasons -- could I ask whether your main use case would be for the dialog where it lists all your reasons or for the actual checkboxes when editing?

Nc432o5 commented 5 years ago

@shu8 I don't care about the order in the dialog, the main use would be for the actual checkboxes while editing. My thought for this is to be able to move the reasons around in the dialog and the changes would be reflected in the editing screen.