Closed double-beep closed 5 years ago
Thanks for the bug report! (and I'm glad you find the feature awesome!)
I'll get this fixed ASAP -- probably using your regex! :P
On Fri, 24 May 2019, 17:43 Double Beep, notifications@github.com wrote:
Describe the bug It is well-known that SOX has an awesome feature(!) to quickly-view questions and answer, e.g.:
[image: image] https://user-images.githubusercontent.com/38133098/58343419-9648fc00-7e5b-11e9-8e0e-1c54fa71e214.png
However, when there is a link, e.g. https://stackoverflow.com/questions/ask, then SOX interprets this as a question and...:
[image: image] https://user-images.githubusercontent.com/38133098/58343501-d6a87a00-7e5b-11e9-9b19-e1b24d7fee8a.png
To Reproduce Steps to reproduce the behaviour:
- Go and see a random comment which contains https://sitename.com/questions/ask
- Press the button.
- Saw thee result? Nothing happens
Expected behaviour SOX shouldn't at all consider https://sitename.com/questions/ask as a question!
I haven't dug into the code, but I suppose that it should use a regex to understand if it is a question or not, right? How about whatever.com/questions/[0-9] <http://whatever.com/questions/%5B0-9%5D> or whatever possible.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/soscripted/sox/issues/392?email_source=notifications&email_token=ACDQ3DU5K3T5LERCONZHVZ3PXALLLA5CNFSM4HPRCTV2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GVX5IKQ, or mute the thread https://github.com/notifications/unsubscribe-auth/ACDQ3DRBJWUSHGWUDDHPAE3PXALLLANCNFSM4HPRCTVQ .
@double-beep It's surprisingly hard to find a comment like that (probably because the post ends up being deleted!) -- do you mind posting the link you saw that on, so I can test the fix works?
Yyyyyyep! Here is one!
Thanks! Should be fixed in dev 2.4.15 :)
Cheers!
Describe the bug It is well-known that SOX has an awesome feature(!) to quickly-view questions and answer, e.g.:
However, when there is a link, e.g. https://stackoverflow.com/questions/ask, then SOX interprets this as a question and...:
To Reproduce Steps to reproduce the behaviour:
Expected behaviour SOX shouldn't at all consider https://sitename.com/questions/ask as a question!
I haven't dug into the code, but I suppose that it should use a regex to understand if it is a question or not, right? How about
whatever.com/questions/[0-9]*
or whatever possible.