search

soscripted / sox

Stack Overflow Extras: a userscript for the Stack Exchange websites to add a bunch of optional toggle-able features
http://stackapps.com/q/6091/
MIT License
72 stars 15 forks source link

Do not change the span's title when having the option to convert timestamps to local time enables #401

Closed double-beep closed 5 years ago

double-beep commented 5 years ago

It is known that the time a post is posted is inside a <span> tag:

image

where the HTML code is:

image

However, if the option "Convert timestamps to your local time", it affects the title to be the same as span's text. This is something I can't allow, since I am using another userscript which should fetch the time a post was posted originally, at UTC and in the time format YYYY-MM-DD HH:MM:SSZ.

There was a line which originally replaced both the title and the text with the newTimestamp. I have removed the attr(), so now only the span text is replaced.

Does that hurt? AFAIK, this title isn't used elsewhere in SOX, so, it is OK removing it, right?

shu8 commented 5 years ago

Thanks @double-beep! This makes sense to me, not sure why the title was changed in the first place!