soscripted / sox

Stack Overflow Extras: a userscript for the Stack Exchange websites to add a bunch of optional toggle-able features
http://stackapps.com/q/6091/
MIT License
72 stars 15 forks source link

Suggested difference highlights title difference by line not by word #413

Closed SmartManoj closed 5 years ago

SmartManoj commented 5 years ago

https://meta.stackoverflow.com/questions/386853/suggested-difference-highlights-title-difference-by-line-not-by-word

double-beep commented 5 years ago

Options you are using? Cannot reproduce:

image

Any other userscripts you are using?

SmartManoj commented 5 years ago

Disabled all other userscripts and userstyles.

shu8 commented 5 years ago

From your screenshot in the Meta.SO post:

If you look closely at the left of the title, there is a black toggle icon which would toggle it. Unfortunately your dark theme makes this difficult to see.

Feel free to disable the feature if this isn't something you want. The feature is:

Make title edits show separately rather than merged in edit suggestions

Under the 'Editing' section in the settings dialog.

Closing this as it isn't a bug, but it is related to #406. I'd welcome any pull requests for helping support the dark theme, but unfortunately this won't be very high priority for me.

SmartManoj commented 5 years ago

Options you are using? Cannot reproduce:

image

Any other userscripts you are using?

image @shu8 Both are different

shu8 commented 5 years ago

Yes, the toggle button toggles which view you see:

diff

SmartManoj commented 5 years ago

Options you are using? Cannot reproduce:

image

Any other userscripts you are using?

The strikes

shu8 commented 5 years ago

Could you elaborate? I'm not sure what you mean.

SmartManoj commented 5 years ago

Yes, the toggle button toggles which view you see:

diff

Only insert should be highlighted when toggle is on like in https://github.com/soscripted/sox/issues/413#issuecomment-508432741

shu8 commented 5 years ago

Sorry, still not sure what you mean!

The point of the feature is to just show a before and after view, just like in the feature request here, and has always worked like this

SmartManoj commented 5 years ago

Options you are using? Cannot reproduce: image Any other userscripts you are using?

image @shu8 Both are different

first one is more readable and easy to identify only the difference

SmartManoj commented 5 years ago

Options you are using? Cannot reproduce:

image

Any other userscripts you are using?

@double-beep How do you get this? Because yours' is different from this