search

soscripted / sox

Stack Overflow Extras: a userscript for the Stack Exchange websites to add a bunch of optional toggle-able features
http://stackapps.com/q/6091/
MIT License
72 stars 15 forks source link

Hot Network Questions (isQuestionHot) broken with recent SE sidebar change #419

Closed shu8 closed 5 years ago

shu8 commented 5 years ago

Describe the bug The isQuestionHot feature throws an exception and does nothing.

To Reproduce Steps to reproduce the behaviour:

  1. Go to any recent hot network question (e.g. this at the time of writing)
  2. There's not hot network question text or icon

SOX errors logged in console

Uncaught TypeError: Cannot set property 'innerHTML' of null
    at addHotText (userscript.html?id=cf7158da-e94f-410f-9033-e1aedd3cbc41:1725)
    at Object.eval (userscript.html?id=cf7158da-e94f-410f-9033-e1aedd3cbc41:1740)
    at Function.each (userscript.html?id=cf7158da-e94f-410f-9033-e1aedd3cbc41:7)
    at Object.eval [as success] (userscript.html?id=cf7158da-e94f-410f-9033-e1aedd3cbc41:1739)
    at u (userscript.html?id=cf7158da-e94f-410f-9033-e1aedd3cbc41:7)
    at Object.fireWith [as resolveWith] (userscript.html?id=cf7158da-e94f-410f-9033-e1aedd3cbc41:7)
    at k (userscript.html?id=cf7158da-e94f-410f-9033-e1aedd3cbc41:7)
    at XMLHttpRequest.eval (userscript.html?id=cf7158da-e94f-410f-9033-e1aedd3cbc41:7)

Expected behaviour A flame icon next to the title, and some sort of text near the top of the question saying the question is a HNQ.

Environment SOX version: 2.5.19 dev Platform: Tampermonkey

Features Enabled

["Appearance-addAuthorNameToInboxNotifications","Appearance-answerTagsSearch","Appearance-colorAnswerer","Appearance-displayName","Appearance-dragBounty","Appearance-highlightQuestions","Appearance-isQuestionHot","Appearance-markEmployees","Appearance-metaChatBlogStackExchangeButton","Appearance-metaNewQuestionAlert","Appearance-scrollToTop","Appearance-standOutDupeCloseMigrated","Appearance-tabularReviewerStats","Appearance-topAnswers","Appearance-addTimelineAndRevisionLinks","Appearance-showTagWikiLinkOnTagPopup","Appearance-hideWelcomeBackMessage","Appearance-hideHowToAskWhenZoomed","Comments-autoShowCommentImages","Comments-commentReplies","Comments-commentShortcuts","Comments-confirmNavigateAway","Comments-copyCommentsLink","Comments-showCommentScores","Comments-onlyShowCommentActionsOnHover","Editing-addSBSBtn","Editing-editComment","Editing-editReasonTooltip","Editing-findAndReplace","Editing-kbdAndBullets","Editing-titleEditDiff","Editing-inlineEditorEverywhere","Flags-flagOutcomeTime","Flags-flagPercentages","Flags-flagPercentageBar","Sidebar-hideLoveThisSite","Chat-chatEasyAccess","Chat-replyToOwnChatMessages","Chat-renameChat","Voting-betterCSS","Voting-stickyVoteButtons","Voting-disableVoteButtons","Extras-linkedPostsInline","Extras-quickAuthorInfo","Extras-shareLinksPrivacy","Extras-shareLinksMarkdown","Extras-sortByBountyAmount","Extras-warnNotLoggedIn","Extras-copyCode","Extras-showQuestionStateInSuggestedEditReviewQueue","Extras-addOnTopicLinkToSiteSwitcher","Extras-customMagicLinks"]
shu8 commented 5 years ago

@fixer1234 just fixed this in dev 2.5.21 :)