Closed mlaunois closed 4 years ago
Thanks for the bug report! Unfortunately I won't be able to look into this until a few weeks. I'd be happy to review a pull request if you're able to submit one but otherwise it may be a few weeks till I get time!
On Sun, 18 Aug 2019, 22:57 Maxime Launois, notifications@github.com wrote:
Description
The Stack Overflow Extras do not load when I'm logged out on stackoverflow.com. It does work on every other SE site. Steps to reproduce
- Log out https://stackoverflow.com/users/logout from Stack Overflow
- Confirm the logout: [image: Logging out from Stack Overflow] https://user-images.githubusercontent.com/47182594/63226062-88dfab80-c1d7-11e9-9c8f-b4b8848b5bef.png
- The SOX settings button is missing from the topbar.
SOX errors logged in console
Uncaught SOX: There was an error while attempting to initialize the SOX Settings Dialog, please report this on GitHub. TypeError: Cannot read property 'left' of undefined
Expected behaviour
The SOX settings button should appear on the Stack Overflow topbar, like on Meta Stack Overflow: [image: Meta Stack Overflow topbar] https://user-images.githubusercontent.com/47182594/63226285-6c903e80-c1d8-11e9-9b70-3907ad53a4ed.png Screenshots
[image: Screenshot 1] https://user-images.githubusercontent.com/47182594/63225905-1cb07800-c1d6-11e9-8024-c9441fb0b4b4.png Environment
SOX version: 2.5.23 DEV Platform: Violentmonkey Browser: Chrome 64-bit 74.0.3729.108
Features enabled
[ "Appearance-addAuthorNameToInboxNotifications", "Appearance-alignBadgesByClass", "Appearance-answerTagsSearch", "Appearance-colorAnswerer", "Appearance-displayName", "Appearance-dragBounty", "Appearance-highlightQuestions", "Appearance-isQuestionHot", "Appearance-localTimestamps", "Appearance-markEmployees", "Appearance-metaChatBlogStackExchangeButton", "Appearance-metaNewQuestionAlert", "Appearance-scrollToTop", "Appearance-spoilerTip", "Appearance-standOutDupeCloseMigrated", "Appearance-tabularReviewerStats", "Appearance-topAnswers", "Appearance-unspoil", "Appearance-addTimelineAndRevisionLinks", "Appearance-showTagWikiLinkOnTagPopup", "Appearance-hideWelcomeBackMessage", "Appearance-hideHowToAskWhenZoomed", "Comments-autoShowCommentImages", "Comments-commentReplies", "Comments-commentShortcuts", "Comments-confirmNavigateAway", "Comments-copyCommentsLink", "Comments-moveBounty", "Comments-showCommentScores", "Comments-hiddenCommentsIndicator", "Comments-onlyShowCommentActionsOnHover", "Editing-addSBSBtn", "Editing-editComment", "Editing-editReasonTooltip", "Editing-findAndReplace", "Editing-kbdAndBullets", "Editing-titleEditDiff", "Editing-inlineEditorEverywhere", "Flags-flagOutcomeTime", "Flags-flagPercentages", "Flags-flagPercentageBar", "Sidebar-hideCommunityBulletin", "Sidebar-hideJustHotMetaPosts", "Sidebar-hideHireMe", "Sidebar-hideChatSidebar", "Sidebar-hideLoveThisSite", "Sidebar-linkedToFrom", "Sidebar-hotNetworkQuestionsFiltering", "Chat-chatEasyAccess", "Chat-replyToOwnChatMessages", "Chat-renameChat", "Voting-betterCSS", "Voting-stickyVoteButtons", "Voting-disableVoteButtons", "Extras-linkedPostsInline", "Extras-parseCrossSiteLinks", "Extras-quickAuthorInfo", "Extras-shareLinksPrivacy", "Extras-shareLinksMarkdown", "Extras-sortByBountyAmount", "Extras-warnNotLoggedIn", "Extras-hideCertainQuestions", "Extras-showMetaReviewCount", "Extras-copyCode", "Extras-dailyReviewBar", "Extras-openLinksInNewTab", "Extras-showQuestionStateInSuggestedEditReviewQueue", "Extras-addOnTopicLinkToSiteSwitcher", "Extras-customMagicLinks"]
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/soscripted/sox/issues/423?email_source=notifications&email_token=ACDQ3DTL33RNO5JAKKB7X3DQFFPMRA5CNFSM4IMTHPT2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HF2ZFTQ, or mute the thread https://github.com/notifications/unsubscribe-auth/ACDQ3DV4CJKSKEMMHQOEYU3QFFPMRANCNFSM4IMTHPTQ .
I have confirmed the issue and worked on a fix which is in PR 424. The PR is currently awaiting review. @mlaunois can you check?
This should be fixed in dev 2.5.26 now thanks to @double-beep's PR :)
@doublebeep OK, it works again
Description
The Stack Overflow Extras do not load when I'm logged out on stackoverflow.com. It does work on every other SE site.
Steps to reproduce
SOX errors logged in console
Expected behaviour
The SOX settings button should appear on the Stack Overflow topbar, like on Meta Stack Overflow:![Meta Stack Overflow topbar](https://user-images.githubusercontent.com/47182594/63226285-6c903e80-c1d8-11e9-9b70-3907ad53a4ed.png)
Screenshots
Environment
SOX version: 2.5.23 DEV Platform: Violentmonkey Browser: Chrome 64-bit 74.0.3729.108
Features enabled