soscripted / sox

Stack Overflow Extras: a userscript for the Stack Exchange websites to add a bunch of optional toggle-able features
http://stackapps.com/q/6091/
MIT License
72 stars 15 forks source link

Add scrolling to chat room lists #442

Closed LunarWatcher closed 4 years ago

LunarWatcher commented 4 years ago

Describe the feature you'd like

Being in too many rooms hides user info, or hides the full room list along with the actions. There's a bug report on MSE for this. However, it's currently ignored and probably won't be fixed any time soon. The problem is still real.

My FR: add a scrollbar to the chat room list in user cards and, if possible, in the right nav bar (see the bug report on MSE)

Use case

Mainly to avoid not being able to take some actions against specific users who happen to have a long room list.

Suggested descriptions

Enable scrolling in the room list within usercards and in the navbar when there's a significant amount of rooms in the list

shu8 commented 4 years ago

@LunarWatcher I've added this in dev 2.6.5!

Please could you confirm it works? It should look like this:

usercard

sidebar

LunarWatcher commented 4 years ago

Looks good! There's a couple problems though. From the user list on the right:

bilde

The list is partially hidden. From the chat log, clicking on the username on messages still causes some overflow (but significantly less than before):

bilde

And

bilde

(depending on how far I've scrolled and where it opens relative to the line)

Maybe restrict height a bit more? Aside that, from the profile pic the full list of own rooms, it works perfectly fine. (If it matters, I'm using FF. Mentioning this in case it works for you in some other browser)

shu8 commented 4 years ago

Ah, forgot that our own usercards are in other places :P

I've just pushed an update in dev 2.6.6 that just reduces the height a bit more.

If that works for you I think we're safe to leave it at that because it's still not too small, but if it doesn't I'll try adding some sort of JS that calculates a better height instead.

Let me know if it works! :)

LunarWatcher commented 4 years ago

Looks like it works now. Thanks ^^