search

soscripted / sox

Stack Overflow Extras: a userscript for the Stack Exchange websites to add a bunch of optional toggle-able features
http://stackapps.com/q/6091/
MIT License
72 stars 15 forks source link

Not worked? #479

Closed SmartManoj closed 3 years ago

SmartManoj commented 3 years ago

Describe the bug For the first time one have to click save changes in settings to make it work

SOX errors logged in console Not captured

Environment SOX version: 2.6.37DEV Platform: Tampermonkey

SmartManoj commented 3 years ago

Which is the root cause for #463

shu8 commented 3 years ago

Thanks for raising this issue @SmartManoj.

Needing to click "Save Changes" in the settings dialog is desired behaviour. SOX won't do anything until the user explicitly confirms what features they want.

The alternative would be for SOX to decide what features to enable on first-install, which goes against what SOX exists for -- everything should be optional.

SmartManoj commented 3 years ago

Is this new behavior? It should tell the user to click save changes. But it should ask to choose feature on first-install.

shu8 commented 3 years ago

You should get an alert on first install prompting you to get an access token, and the dialog should show up when that alert pops up.

Does that happen for you? If not, please could you follow the issue template and describe steps to reproduce the behaviour, and the exact expected behaviour, to make it easier to debug and track this issue! :)

SmartManoj commented 3 years ago

It does. Will the alert tell the user to click save changes?