soscripted / sox

Stack Overflow Extras: a userscript for the Stack Exchange websites to add a bunch of optional toggle-able features
http://stackapps.com/q/6091/
MIT License
72 stars 15 forks source link

(Down)vote tooltip gets mixed-up with tags and links under the question #492

Closed tomerkal closed 2 years ago

tomerkal commented 2 years ago

For specifically short questions, I noticed that the downvote tooltip (I guess that there is no short enough question to be affected by the upvote tooltip) gets mixed-up with the tags and links under the question. I noticed that the problem only occurs when SOX is on. This issue started out as a Meta SO question.

To Reproduce Steps to reproduce the behaviour:

  1. Go to https://meta.stackoverflow.com/questions/416114/should-i-explain-other-peoples-code?cb=1
  2. Hover over the downvote button
  3. See error - Downvote tooltip gets mixed-up (wrong z-index?) with tags and links.

SOX errors logged in console sb.scorecardresearch.com/cs/17440561/beacon.js:1 Failed to load resource: net::ERR_BLOCKED_BY_CLIENT userscript.html?name=Stack%20Overflow%20Extras%20(SOX).user.js&id=0a445ba2-4a3f-455b-b9ca-815ee5eee2ad:291 SOX: logging sox stored values --- userscript.html?name=Stack%20Overflow%20Extras%20(SOX).user.js&id=0a445ba2-4a3f-455b-b9ca-815ee5eee2ad:291 SOX: access token set userscript.html?name=Stack%20Overflow%20Extras%20(SOX).user.js&id=0a445ba2-4a3f-455b-b9ca-815ee5eee2ad:291 SOX: SOX-apiCache userscript.html?name=Stack%20Overflow%20Extras%20(SOX).user.js&id=0a445ba2-4a3f-455b-b9ca-815ee5eee2ad:291 SOX: {"standOutDupeCloseMigrated":{"questions":[{"closed_details":{"by_users":[{"display_name":"SuperStormer"},{"display_name":"kaya3"}],"original_questions":[{"question_id":9062562,"title":"What is the internal precision of numpy.float128?"}],"reason":"Duplicate"},"closed_date":1627326830,"creation_date":1627326019,"question_id":68535160,"link":"https://stackoverflow.com/questions/68535160/pythons-int-conversion-incorrect","closed_reason":"Duplicate","sox_request_time":1627333230966},{"closed_details":{"by_users":[{"display_name":"Wiktor Stribiżew"}],"original_questions":[{"question_id":45800695,"title":"Regex for numbers after a certain string part"}],"reason":"Duplicate"},"closed_date":1627333407,"creation_date":1627333132,"question_id":68536257,"link":"https://stackoverflow.com/questions/68536257/need-to-verify-the-regex-for-a-st21072231","closed_reason":"Duplicate","sox_request_time":1627333867471},{"closed_details":{"by_users":[{"display_name":"αԋɱҽԃ αмєяιcαη"},{"display_name":"Idos"},{"display_name":"Tomerikoo"}],"reason":"Not suitable for this site"},"closed_date":1627333717,"creation_date":1627332960,"question_id":68536226,"link":"https://stackoverflow.com/questions/68536226/remove-last-comma-from-a-string-python","closed_reason":"Not suitable for this site","sox_request_time":1627333867471},{"closed_details":{"by_users":[{"display_name":"eyllanesc"}],"original_questions":[{"question_id":58770646,"title":"Autocomplete from .ui"}],"reason":"Duplicate"},"closed_date":1627332879,"creation_date":1627332525,"question_id":68536171,"link":"https://stackoverflow.com/questions/68536171/pyside6-does-not-return-qobject-for-findchild","closed_reason":"Duplicate","sox_request_time":1627333867471},{"closed_details":{"by_users":[{"display_name":"Wiktor Stribiżew"}],"original_questions":[{"question_id":159118,"title":"How do I match any character across multiple lines in a regular expression?"}],"reason":"Duplicate"},"closed_date":1627328936,"creation_date":1627328860,"question_id":68535634,"link":"https://stackoverflow.com/questions/68535634/regex-extract-strings-between-2-characters-which-may-or-may-not-contain-a-new-li","closed_reason":"Duplicate","sox_request_time":1627333867471},{"closed_details":{"by_users":[{"display_name":"esqew"},{"display_name":"RavinderSingh13"},{"display_name":"Life is complex"}],"reason":"Needs details or clarity"},"closed_date":1627331216,"creation_date":1627328628,"question_id":68535594,"link":"https://stackoverflow.com/questions/68535594/how-to-work-with-the-data-of-a-custom-dataset-in-pytorch","closed_reason":"Needs details or clarity","sox_request_time":1627333867471},{"closed_details":{"by_users":[{"display_name":"mkrieger1"},{"display_name":"Charles Duffy"},{"display_name":"Sayse"}],"reason":"Needs details or clarity"},"closed_date":1627328524,"creation_date":1627327908,"question_id":68535490,"link":"https://stackoverflow.com/questions/68535490/snapshot-of-directory-to-restore-later-on","closed_reason":"Needs details or clarity","sox_request_time":1627333867471},{"closed_details":{"by_users":[{"display_name":"Machavity"}],"reason":"Needs details or clarity"},"closed_date":1627322429,"creation_date":1627322358,"question_id":68534525,"link":"https://stackoverflow.com/questions/68534525/how-to-get-the-title-using-beautifulsoup-and-requests-on-python","closed_reason":"Needs details or clarity","sox_request_time":1627333867471},{"closed_details":{"by_users":[{"display_name":"Rabbid76"}],"original_questions":[{"question_id":58177145,"title":"Could not open resource file: pygame.error: Couldn't open sprite/test_bg.jpg"}],"reason":"Duplicate"},"closed_date":1627322722,"creation_date":1627321429,"question_id":68534346,"link":"https://stackoverflow.com/questions/68534346/self-image-pygame-image-loadskier-down-png","closed_reason":"Duplicate","sox_request_time":1627333867471},{"closed_details":{"by_users":[{"display_name":"tripleee"}],"original_questions":[{"question_id":8949252,"title":"Why do I get AttributeError: 'NoneType' object has no attribute 'something'?"}],"reason":"Duplicate"},"closed_date":1627320790,"creation_date":1627318895,"question_id":68533810,"link":"https://stackoverflow.com/questions/68533810/attributeerror-networkx-nonetype-object-has-no-attribute-get","closed_reason":"Duplicate","sox_request_time":1627333867471},{"closed_details":{"by_users":[{"display_name":"Tomerikoo"},{"display_name":"Josh Smeaton"}],"original_questions":[{"question_id":10929724,"title":"Which is the most efficient way to iterate through a list in python?"}],"reason":"Duplicate"},"closed_date":1627366389,"creation_date":1627365550,"question_id":68539657,"link":"https://stackoverflow.com/questions/68539657/speed-of-for-loop-vs-for-item-loop","closed_reason":"Duplicate","sox_request_time":1627367459083},{"closed_details":{"by_users":[{"display_name":"blhsing"}],"original_questions":[{"question_id":10867882,"title":"Tuple unpacking in for loops"}],"reason":"Duplicate"},"closed_date":1 userscript.html?name=Stack%20Overflow%20Extras%20(SOX).user.js&id=0a445ba2-4a3f-455b-b9ca-815ee5eee2ad:291 SOX: SOX-lastVersionInstalled userscript.html?name=Stack%20Overflow%20Extras%20(SOX).user.js&id=0a445ba2-4a3f-455b-b9ca-815ee5eee2ad:291 SOX: 2.7.0 userscript.html?name=Stack%20Overflow%20Extras%20(SOX).user.js&id=0a445ba2-4a3f-455b-b9ca-815ee5eee2ad:291 SOX: SOXSETTINGS userscript.html?name=Stack%20Overflow%20Extras%20(SOX).user.js&id=0a445ba2-4a3f-455b-b9ca-815ee5eee2ad:291 SOX: ["Appearance-colorAnswerer","Appearance-displayName","Appearance-localTimestamps","Appearance-metaChatBlogStackExchangeButton","Appearance-scrollToTop","Appearance-standOutDupeCloseMigrated","Appearance-tabularReviewerStats","Appearance-showTagWikiLinkOnTagPopup","Comments-commentReplies","Comments-commentShortcuts","Comments-confirmNavigateAway","Comments-hiddenCommentsIndicator","Comments-onlyShowCommentActionsOnHover","Editing-addSBSBtn","Editing-editComment","Editing-findAndReplace","Editing-kbdAndBullets","Editing-titleEditDiff","Flags-flagOutcomeTime","Flags-flagPercentages","Flags-flagPercentageBar","Sidebar-hideHireMe","Sidebar-hideLoveThisSite","Sidebar-linkedToFrom","Chat-chatEasyAccess","Chat-replyToOwnChatMessages","Chat-renameChat","Chat-scrollChatRoomsList","Voting-stickyVoteButtons","Extras-shareLinksMarkdown","Extras-sortByBountyAmount","Extras-copyCode","Extras-dailyReviewBar","Extras-openLinksInNewTab","Extras-addOnTopicLinkToSiteSwitcher","Extras-customMagicLinks"] userscript.html?name=Stack%20Overflow%20Extras%20(SOX).user.js&id=0a445ba2-4a3f-455b-b9ca-815ee5eee2ad:291 SOX: editReasons userscript.html?name=Stack%20Overflow%20Extras%20(SOX).user.js&id=0a445ba2-4a3f-455b-b9ca-815ee5eee2ad:291 SOX: [{"formatting":"improved formatting"},{"spelling":"corrected spelling"},{"grammar":"fixed grammar"},{"greetings":"removed thanks/greetings"},{"retag":"improved usage of tags"},{"title":"improved title"}] userscript.html?name=Stack%20Overflow%20Extras%20(SOX).user.js&id=0a445ba2-4a3f-455b-b9ca-815ee5eee2ad:291 SOX: SOX-debug userscript.html?name=Stack%20Overflow%20Extras%20(SOX).user.js&id=0a445ba2-4a3f-455b-b9ca-815ee5eee2ad:291 SOX: true DevTools failed to load source map: Could not load content for chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/jquery.timeago.min.js.map: HTTP error: status code 404, net::ERR_UNKNOWN_URL_SCHEME

Expected behaviour At normal circumstances, the tooltip is at the foreground, in front of any other elements.

Screenshots/GIFs Image of the problem

Environment OS: Windows 10 Browser: Vivaldi 5.1.2567.49 SOX version: 2.7.0 Platform: Tampermonkey


Features Enabled

["Appearance-colorAnswerer","Appearance-displayName","Appearance-localTimestamps","Appearance-metaChatBlogStackExchangeButton","Appearance-scrollToTop","Appearance-standOutDupeCloseMigrated","Appearance-tabularReviewerStats","Appearance-showTagWikiLinkOnTagPopup","Comments-commentReplies","Comments-commentShortcuts","Comments-confirmNavigateAway","Comments-hiddenCommentsIndicator","Comments-onlyShowCommentActionsOnHover","Editing-addSBSBtn","Editing-editComment","Editing-findAndReplace","Editing-kbdAndBullets","Editing-titleEditDiff","Flags-flagOutcomeTime","Flags-flagPercentages","Flags-flagPercentageBar","Sidebar-hideHireMe","Sidebar-hideLoveThisSite","Sidebar-linkedToFrom","Chat-chatEasyAccess","Chat-replyToOwnChatMessages","Chat-renameChat","Chat-scrollChatRoomsList","Voting-stickyVoteButtons","Extras-shareLinksMarkdown","Extras-sortByBountyAmount","Extras-copyCode","Extras-dailyReviewBar","Extras-openLinksInNewTab","Extras-addOnTopicLinkToSiteSwitcher","Extras-customMagicLinks"]
shu8 commented 2 years ago

Hi, thank you so much for the bug report! I had actually missed this issue somehow but the fix was just a one-liner -- it should now be working in dev 2.7.14!

I'm sorry for the late response, please do let me know if there's anything else wrong! :)