search

soscripted / sox

Stack Overflow Extras: a userscript for the Stack Exchange websites to add a bunch of optional toggle-able features
http://stackapps.com/q/6091/
MIT License
72 stars 15 forks source link

No side-by-side editing button #62

Closed fixer1234 closed 8 years ago

fixer1234 commented 8 years ago

Installed Version: 1.0.3 | Firefox/Greasemonkey (Windows 7)

Expected Behavior How do you expect the feature to work?

Assume the side-by-side editing "button" is similar to that in the standalone script (text in the editing toolbar).

Actual Behavior How is the feature currently behaving?

No button/link I can find anywhere to toggle side-by-side editing

Error Logs SOX errors are logged to the browser console, if possible, please post those here.

Not familiar with this.

Steps to reproduce What steps did you take to reproduce the issue?

Installed script, tried to edit both answers and questions (no side-by-side option on either). Haven't exhaustively checked the other numerous features, but many new features and the settings gears are visible, so the script successfully installed.

shu8 commented 8 years ago

@fixer1234 could you try searching for 'side' in the search box in the settings panel (click the gear icon) and make sure Add a button to the editor toolbar to start side-by-side editing is checked.

Also, try pressing ctrl + shift + j to open the 'console'. Could you copy/paste anything you see there to help debugging this please?

thanks!! :)

fixer1234 commented 8 years ago

The first thing I verified was that the feature was checked (also verified that the computer was plugged in :-} ). Here's the console content:

Use of Mutation Events is deprecated. Use MutationObserver instead. options-content.js:36:0
mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create panel.js:5901:3
Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help http://xhr.spec.whatwg.org/ panel.js:3610:3
not well-formed messages.json:1:1
vwof plugin, exception in ScreenWaveMedia: TypeError: video_data is undefined vwof.js:67:0
1461536826919   Services.HealthReport.HealthReporter    WARN    Saved state file does not exist.
**ReferenceError: waitForKeyElements is not defined sox.features.js:1275:13**
This site makes use of a SHA-1 Certificate; it's recommended you use certificates with signature algorithms that use hash functions stronger than SHA-1.[Learn More] qa.sockets.stackexchange.com
Use of getPreventDefault() is deprecated.  Use defaultPrevented instead. jquery.min.js:3:6598
Content Security Policy: Directive 'frame-src' has been deprecated. Please use directive 'child-src' instead. <unknown>
call to eval() blocked by CSP <unknown>
vwof plugin, exception in ScreenWaveMedia: TypeError: video_data is undefined vwof.js:67:0
Empty string passed to getElementById(). github-f83ae2f0d483dddc8f1894b3cc2709ff1db48511ddc8d054ed639c52c80d54c9.js:6:20273
Empty string passed to getElementById(). frameworks-989d38f4923487cfd9bb7181fd4f1a7ae1c279f2a1318efe9c593f34de850870.js:9:31625
**Content Security Policy: The page's settings blocked the loading of a resource at self ("script-src https://assets-cdn.github.com"). sox.helpers.js:2:0**
Empty string passed to getElementById(). frameworks-989d38f4923487cfd9bb7181fd4f1a7ae1c279f2a1318efe9c593f34de850870.js:9:31625
mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create frameworks-989d38f4923487cfd9bb7181fd4f1a7ae1c279f2a1318efe9c593f34de850870.js:1:16542
Empty string passed to getElementById(). frameworks-989d38f4923487cfd9bb7181fd4f1a7ae1c279f2a1318efe9c593f34de850870.js:9:31625
Key event not available on GTK2: key="u" modifiers="accel,shift" browser.xul
Key event not available on GTK2: key="u" modifiers="accel shift" browser.xul
Key event not available on GTK2: key="u" modifiers="control shift" browser.xul
Key event not available on some keyboard layouts: key="c" modifiers="accel,alt" browser.xul
Key event not available on some keyboard layouts: key="i" modifiers="accel,alt,shift" browser.xul
Key event not available on some keyboard layouts: key="z" modifiers="accel, alt, shift" browser.xul
TypeError: keyset is null bootstrap.js:

I see the same waitForKeyElements reference, so it looks like the issue may be the same. Also, might the script be sensitive to ad and/or tracker blockers?

shu8 commented 8 years ago

@fixer1234 thanks a lot! it seems it is a problem with waitforkeyelements again :(

I think I have an idea for a fix and will ping you again tomorrow when I've got a bit of time to actually do it :P

Sorry for the delay! and thanks again! :)

shu8 commented 8 years ago

@fixer1234 sorry for the extreme delay!! had a busy week :/

Please could you uninstall SOX and the original side by side userscript, to make sure there aren't any clashes.

Then, can you install this version of SOX, where I've tweaked and added waitforkeyelements sightly differently.

hopefully, this will work! because I can't actually reproduce this! :/

catb0t commented 8 years ago

Hi @fixer1234! From the console content, it seems like you possibly have other scripts or add-ons installed that might be interfering with SOX's, ahem, hacky ways. :P If you can, try disabling or uninstalling those.

I get:

Key event not available on some keyboard layouts: key="c" modifiers="accel,alt" browser.xul
Key event not available on some keyboard layouts: key="i" modifiers="accel,alt,shift" browser.xul

With the old one, and no such errors with the new one on FF (yay!). However, still no SBS button. (aww (not that I use it anyways))

By the way, to format code-like things (errors, as well) as code, just put three backticks above and below the "code":

```
code goes here
```

gives:

code goes here

Don't forget the newlines before and after the triple-backticks. See more formatting help, if you're curious.

shu8 commented 8 years ago

@catb0t @fixer1234 ah this is Firefox!! sorry - I didn't notice that :/

I'll check again on FF and try to push a fix later today.

sorry for the delay, again! :)

shu8 commented 8 years ago

@catb0t @fixer1234 hmm.. I still can't reproduce this in Firefox! Could you both try disabling any other userscripts you have, leaving the version of SOX I linked to installed?

Something must be clashing with it!! :/

fixer1234 commented 8 years ago

There are over 50 features. Roughly half are of interest to me and many of those are "must haves" that really should be incorporated into the SE sites. When I first loaded SOX, there were many that didn't work (too many for something that has been released to the public), so I assumed that there are a few common denominator problems, some of which might disappear when SBS was fixed, and I wouldn't be surprised if the major cause is other add-ons I have loaded. Figured I would wait until the SBS problem was solved to see the effect before reporting anything.

Yesterday, I uninstalled the old SOX and separate SBS and installed the SOX version from the link a few comments above. The result was that SBS works, along with a couple of other features that previously didn't. But some features that previously worked now don't, and a few things now work differently.

The only other userscript is the auto-comments. SOX has a similar sounding feature, but that would work only if it can use my customized comments. I did disable auto-comments as a test (including restarting FF), but that didn't affect anything in SOX. Auto-comments had indigestion with a few add-ons (Adblock Plus and Ghostery), so those were already disabled on SE sites and aren't the culprits.

I'll do some testing to document what does and doesn't work now, and try to identify any add-ons that could be the problem. It could take a few days.

mezmi commented 8 years ago

@fixer1234 I sincerely apologize for the broken features, most of them have been migrated from an older project and we've changed a lot since then without really going through all of the features to rewrite them and verify that everything is working. That's our fault.

In the the v1.0.4 milestone I am going to go through each individual feature, refactor and optimize everything.

Some features may be depreciated in the process and some others will be added.

Also, feel free to submit pull-requests, @shu8 and I work on this when we have free time, which isn't much.

Again, sorry for the inconvenience and broken features, we'll do our best to get everything working.

fixer1234 commented 8 years ago

Finished a preliminary look at the features and summarized the results in the attached PDF. I haven't yet experimented with disabling add-ons. That could take some time, so let me know if you have any insights that might reduce the job (for example, if you tried a feature and it also doesn't work for you, so it isn't an add-on conflict on my system).

SOX Test.pdf

BTW, I had previously loaded the patched SBS stand-alone in addition to SOX. The feature wasn't working in SOX, but the fixed stand-alone was working.

shu8 commented 8 years ago

@fixer1234 thank you very much for making that file! I'm going to go through the features and will get back to you ASAP!

sorry again for the troubles!

shu8 commented 8 years ago

@fixer1234 Please see this edited version, with a new column with a few comments on everything that isn't working: SOX.Test.pdf

Regarding the SBS issue, the code is exactly the same for the standalone version and the SOX version, so it should work!

Please see if the comments on the file help you fix anything :)

BTW, if you have loads of add ons you don't want to mess with, you can create a different FF profile and just install greasemonkey and SOX on there to see if everything works

fixer1234 commented 8 years ago

Partial success. Revised results (just the previous problem items): SOX Test Updates Only.pdf

My view of the example for Make title edits show seperately rather than merged in edit suggestions: su screenshot2 My understanding from the features link was that interspersing the additions and deletions like this was what the feature was intended to fix.

On Grey out deleted votes, the features description is a bit confusing. I thought this applied to voting on your own posts. Only 10K+ users can see deleted posts other than their own.

There were a few console items that look related:

TypeError: Type does not implements method: modelFor#0buulgteh2g core.js:116:1
TypeError: $node.find(...).eq(...).attr(...) is undefined sox.features.js:1352:28
TypeError: Type does not implements method: modelFor#0buulgteh2g core.js:116:1
Use of getPreventDefault() is deprecated.  Use defaultPrevented instead. jquery.min.js:3:6598
This site makes use of a SHA-1 Certificate; it's recommended you use certificates with signature algorithms that use hash functions stronger than SHA-1.[Learn More] qa.sockets.stackexchange.com
TypeError: Type does not implements method: modelFor#0buulgteh2g core.js:116:1
no element found github-cloud.s3.amazonaws.com:1:1
Content Security Policy: The page's settings blocked the loading of a resource at https://github-cloud.s3.amazonaws.com/ ("base-uri https://github.com"). <unknown>
no element found github-cloud.s3.amazonaws.com:1:1
TypeError: keyset is null bootstrap.js:34:5

There were some vwof plugin errors (like: vwof plugin, exception in ScreenWaveMedia: TypeError: video_data is undefined), which I assume are unrelated.

shu8 commented 8 years ago

@fixer1234 Thanks, please see this updated version: SOX.Test.Updates.Only.pdf

Please also try installing this edited version that should fix the enhanced editor issue: https://gist.github.com/shu8/8bf4a5dfbc0f12fdef42717fa80b0259/raw/22d709a2c491c2086f846c8492a859a1401e760b/fixer%2520debug

Now, provided everything else works, it seems your issues are all to do with the editor toolbar (list+kbd buttons, SBS, enhanced editor). I can only think that something is messing with the toolbar that makes the script unable to add the right buttons. Have you tried creating a different profile to test SOX without any add ons?

Also, could you try checking the console again please? I know I keep asking you to do that, but it is literally the only thing that can actually tell us what is wrong so we can fix it! Sorry for the time this is taking; I hope it can all be fixed soon! :)

fixer1234 commented 8 years ago

@shu8, I clicked on the github link but it just displays a listing of the script.

BTW, on the make title edits show separately issue, the feature is suddenly working on its own (no change on my part). It isn't clear whether the script gets code at runtime and that's been fixed, or this is another example of intermittent performance (how can you even debug that?).

shu8 commented 8 years ago

@fixer1234 sorry, forgot to change the extension. This link should work.

Also, the script does have the code remotely, which sometimes downloads to update -- it's possible you had an old version locally downloaded. Installing this new version^ should delete any previous versions and download the latest versions of everything (make sure you don't have any old SOXes installed!).

fixer1234 commented 8 years ago

@shu8 Installed the new link. Cleared the console and updated settings, tried to get an access token. This generated some console messages, all related only to SOX:

SOX settings saved: ["Appearance-metaNewQuestionAlert","Appearance-linkedToFrom","Appearance-addEllipsis","Appearance-standOutDupeCloseMigrated","Appearance-scrollToTop","Appearance-addAuthorNameToInboxNotifications","Appearance-markEmployees","Appearance-colorAnswerer","Appearance-tabularReviewerStats","Appearance-fixedTopbar","Appearance-hideCommunityBulletin","Appearance-hideHotNetworkQuestions","Appearance-renameChat","Appearance-metaChatBlogStackExchangeButton","Appearance-answerTagsSearch","Comments-confirmNavigateAway","Comments-commentReplies","Comments-showCommentScores","Comments-commentShortcuts","Comments-autoShowCommentImages","Editing-addSBSBtn","Editing-editReasonTooltip","Editing-kbdAndBullets","Editing-enhancedEditor","Editing-titleEditDiff","Flags-flagPercentages","Flags-flagOutcomeTime","Unsorted-downvotedPostsEditAlert","Unsorted-alwaysShowImageUploadLinkBox","Unsorted-shareLinksMarkdown","Unsorted-linkedPostsInline","Unsorted-parseCrossSiteLinks"] fixer%252520debug.user.js:92:13
The connection to ws://qa.sockets.stackexchange.com/ was interrupted while the page was loading. full.en.js:1:5130
vwof plugin, exception in ScreenWaveMedia: TypeError: video_data is undefined vwof.js:67:0
Use of getPreventDefault() is deprecated.  Use defaultPrevented instead. jquery.min.js:3:6598
no element found 381b:1:1
This site makes use of a SHA-1 Certificate; it's recommended you use certificates with signature algorithms that use hash functions stronger than SHA-1.[Learn More] qa.sockets.stackexchange.com
ReferenceError: waitForKeyElements is not defined sox.features.js:1313:21
mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create panel.js:5813:3
Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help http://xhr.spec.whatwg.org/ panel.js:3522:3
not well-formed messages.json:1:1

I haven't started any kind of exhaustive checking, yet, but re: edit issues: the only changes to the default edit window is Find&Replace+AutoCorrect. No SBS, KBD, etc.

Question on access tokens: it looks like inbox notification on question edit is the only (selected) feature requiring a token. That still says I need to be on SO to get it. Is that the only site where the feature will work? I'm not a programmer, so I don't use SO. However, I'm happy to do some diagnostics for you if it will be useful. If so, what is the expected behavior and how does the button work? (is it a toggle or each click will attempt to get a token? What feedback am I looking for to know if anything resulted from the click?)

It just occurred to me that I'm testing SOX on several different computers. The previous results were from my main computer running Debian Wheezy; Firefox is pretty "enhanced". The current test with your new link is on a laptop running Windows 7. Firefox has fewer add-ons (the ones it has are a subset of the other computer). So that may explain differences in SOX performance. However, I wouldn't expect features that worked on the more enhanced Firefox to not work one the less enhanced one.

While I was editing this comment, some additional messages appeared in the console:

TypeError: this._recipeManager is null LoginManagerParent.jsm:185:9
TypeError: this._recipeManager is null LoginManagerParent.jsm:185:9
mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create panel.js:5813:3
Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help http://xhr.spec.whatwg.org/ panel.js:3522:3
not well-formed messages.json:1:1

One other bug to report (also happened with the previous version). If the SOX configuration menu is open, sometimes (not always), when moving the cursor to select another browser tab and it passes over the StackExchange icon, the SE site selection menu pops up in corrupted form (partial information; e.g., no "other sites" listed), and it's unresponsive. The only way to clear it is to reload the page. Possibly related to the feature that adds links on hover? Some additional console entries covering the period of this event:

TypeError: this._recipeManager is null LoginManagerParent.jsm:185:9
vwof plugin, exception in ScreenWaveMedia: TypeError: video_data is undefined vwof.js:67:0
Use of getPreventDefault() is deprecated.  Use defaultPrevented instead. jquery.min.js:3:6598
http://superuser.com/questions : Unable to run script because scripts are blocked internally. <unknown>
not well-formed <unknown>:1:128
ReferenceError: waitForKeyElements is not defined sox.features.js:1318:13
vwof plugin, exception in ScreenWaveMedia: TypeError: video_data is undefined vwof.js:67:0
no element found 3a9b:1:1
Use of getPreventDefault() is deprecated.  Use defaultPrevented instead. jquery.min.js:3:6598
ReferenceError: waitForKeyElements is not defined sox.features.js:1313:21
The connection to wss://qa.sockets.stackexchange.com/ was interrupted while the page was loading. full.en.js:1:5130
vwof plugin, exception in ScreenWaveMedia: TypeError: video_data is undefined vwof.js:67:0
http://superuser.com/questions : Unable to run script because scripts are blocked internally. <unknown>
not well-formed <unknown>:1:128
ReferenceError: waitForKeyElements is not defined sox.features.js:1318:13
Use of getPreventDefault() is deprecated.  Use defaultPrevented instead. jquery.min.js:3:6598
vwof plugin, exception in ScreenWaveMedia: TypeError: video_data is undefined vwof.js:67:0
no element found 3a9b:1:1
Use of getPreventDefault() is deprecated.  Use defaultPrevented instead. jquery.min.js:3:6598
ReferenceError: waitForKeyElements is not defined sox.features.js:1313:21
mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create panel.js:5813:3
Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help http://xhr.spec.whatwg.org/ panel.js:3522:3
not well-formed messages.json:1:1
mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create panel.js:5813:3
Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help http://xhr.spec.whatwg.org/ panel.js:3522:3
not well-formed messages.json:1:1

I noticed the waitforkey elements is back. Also a message about scripts being blocked internally. Is that likely about 3rd party add-ons?

shu8 commented 8 years ago

@fixer1234 thanks for all the console dumps! They really do help.

It seems the issue is the waitforkeyelements again. weird, but I've changed the version again to include it in a different way. Please (sorry for doing this so many times!) install this SOX version now. It includes waitforkeyelements in a different way which should work!

About your access token question: you only need to be on SO to actually get the access token. Once the access token is saved, it will work on any site. So, what should happen is:

then it should work: clicking on 'notify on edit' should make it turn green (will make that more obvious soon), and an edit should trigger a notification. Here's an answer that describes how it works (note; the eye icon has been replaced with the 'notify on edit' text!).

I have reproduced your bug with the StackExchange button -- it's actually an issue with the hovering over the button thing. This will be fixed in 1.0.4.

Finally, I still think it could be an add on you've installed that's not making the SBS and other features work! I think that more are working on your other computer because that 'thing' isn't there. Please do try to create a new FF profile, and just install Greasemonkey and SOX (with the link I posted at the beginning of this comment). Then, hopefully, everything should work. I say this because I can't reproduce the reference errors to waitforkeyelements, so there must be something blocking it.

fixer1234 commented 8 years ago

@shu8: Loaded the revised script and just took a quick look at the edit box and tokens. The tokens link didn't work. The edit box has Find/Replace and Auto Correct, and the SBS link (only additional features). SBS doesn't work. It provides a centered edit box followed by the preview. Console contents:

mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create frameworks-90fadde68d68d108f0318274e0f72c8e36717b821c919eb6884c738f6bef8470.js:1:16542
vwof plugin, exception in ScreenWaveMedia: TypeError: video_data is undefined vwof.js:67:0
The connection to wss://live.github.com/_sockets/MTAwNjU3NjY6NzQzOGYwMTBlY2Q4ZjdhOGExZGJjOTNiMWU4MTdhYmU6ZWQ2NTk3NDBmNzAzNDk4NzllMjc3MDZmMzc3OTEwMjAzZTc2Zjg5NGI5ZjcyZjQxNjlmOGE5ZWQxOTEwYTk0OA==--ea5337ed952962ce10895e9b4ee02d633c59c05a was interrupted while the page was loading. github-b34f54eabccd0ffa90e322cffdb0db239d492b9a986092f1aa602c5cf84d36b4.js:4:29239
TypeError: keyset is null bootstrap.js:34:5
mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create panel.js:5813:3
vwof plugin, exception in ScreenWaveMedia: TypeError: video_data is undefined vwof.js:67:0
mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create panel.js:5813:3
Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help http://xhr.spec.whatwg.org/ panel.js:3522:3
not well-formed messages.json:1:1
vwof plugin, exception in ScreenWaveMedia: TypeError: video_data is undefined vwof.js:67:0
This site makes use of a SHA-1 Certificate; it's recommended you use certificates with signature algorithms that use hash functions stronger than SHA-1.[Learn More] qa.sockets.stackexchange.com
Use of getPreventDefault() is deprecated.  Use defaultPrevented instead. jquery.min.js:3:6598
vwof plugin, exception in ScreenWaveMedia: TypeError: video_data is undefined vwof.js:67:0
g is null jquery-2.1.4.min.js:3:19226
vwof plugin, exception in ScreenWaveMedia: TypeError: video_data is undefined vwof.js:67:0
TypeError: l is not a function all.js:1:491
vwof plugin, exception in ScreenWaveMedia: TypeError: video_data is undefined vwof.js:67:0
TypeError: l is not a function all.js:1:491
TypeError: $node.find(...).eq(...).attr(...) is undefined sox.features.js:1354:28
vwof plugin, exception in ScreenWaveMedia: TypeError: video_data is undefined vwof.js:67:0
Key event not available on GTK2: key="u" modifiers="accel,shift" browser.xul
Key event not available on GTK2: key="u" modifiers="accel shift" browser.xul
Key event not available on GTK2: key="u" modifiers="control shift" browser.xul
Key event not available on some keyboard layouts: key="c" modifiers="accel,alt" browser.xul
Key event not available on some keyboard layouts: key="i" modifiers="accel,alt,shift" browser.xul
Key event not available on some keyboard layouts: key="z" modifiers="accel, alt, shift" browser.xul
TypeError: keyset is null bootstrap.js:34:5
mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create panel.js:5813:3
Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help http://xhr.spec.whatwg.org/ panel.js:3522:3
not well-formed messages.json:1:1

I created a new profile and loaded just greasemonkey and this latest SOX. Performance was exactly as described above for the original profile. Console output:

Strict-Transport-Security: The site specified a header that could not be parsed successfully.[Learn More] opensocial
Strict-Transport-Security: The site specified a header that could not be parsed successfully.[Learn More] getI18N
The connection to wss://wms.zoho.com/pconnect?prd=VO&config=207&wmsid=39002439&dname= was interrupted while the page was loading. wmsmdsock.html:11:9205
The connection to wss://wms.zoho.com/pconnect?prd=VO&i=NENVk86NDU3MDg0NDA4Mjk1MDk4MDg5NzozOTAwMjQzOToyMDc6LTE%253D was interrupted while the page was loading. wmsmdsock.html:11:9205
This site makes use of a SHA-1 Certificate; it's recommended you use certificates with signature algorithms that use hash functions stronger than SHA-1.[Learn More] qa.sockets.stackexchange.com
Use of getPreventDefault() is deprecated.  Use defaultPrevented instead. jquery.min.js:3:6598
The connection to wss://wms.zoho.com/pconnect?prd=VO&i=NENVk86NDU3MDg0NDA4Mjk1MDk4MDg5NzozOTAwMjQzOToyMDc6LTE%253D was interrupted while the page was loading. wmsmdsock.html:11:9205
TypeError: $node.find(...).eq(...).attr(...) is undefined sox.features.js:1354:28
TypeError: l is not a function all.js:1:491
The connection to wss://wms.zoho.com/pconnect?prd=VO&i=NENVk86NDU3MDg0NDA4Mjk1MDk4MDg5NzozOTAwMjQzOToyMDc6LTE%253D was interrupted while the page was loading. wmsmdsock.html:11:9205
1462332361707   addons.update-checker   WARN    Update manifest for {972ce4c6-7e08-4474-a285-3208198ce6fd} did not contain an updates property
1462332363126   addons.xpi  ERROR   Failed to clean updated system add-ons directories.: Win error 2 during operation DirectoryIterator.prototype.next on file C:\Users\Primary User\AppData\Roaming\Mozilla\Firefox\Profiles\re0r0aen.SOX test\features (The system cannot find the file specified.

) ((unknown module)) No traceback available Log.jsm:751:0
1462332363871   Services.Metrics.Provider.org.mozilla.addons    WARN    Add-on type without field: greasemonkey-user-script
Could not read chrome manifest 'file:///C:/Program%20Files%20(x86)/Mozilla%20Firefox/chrome.manifest'.
1462332363893   addons.xpi  ERROR   Attempted to load bootstrap scope from missing directory C:\Users\Primary User\AppData\Roaming\Mozilla\Firefox\Profiles\re0r0aen.SOX test\extensions\firefox-hotfix@mozilla.org.xpi Log.jsm:751:0
1462332363893   addons.xpi  WARN    Add-on firefox-hotfix@mozilla.org is missing bootstrap method shutdown
Could not read chrome manifest 'file:///C:/Program%20Files%20(x86)/Mozilla%20Firefox/chrome.manifest'.
1462332363898   addons.manager  WARN    Exception calling callback: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIFile.isDirectory]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm :: getURIForResourceInFile :: line 1510"  data: no] Stack trace: getURIForResourceInFile()@resource://gre/modules/addons/XPIProvider.jsm:1510 < this.XPIProvider.callBootstrapMethod()@resource://gre/modules/addons/XPIProvider.jsm:4669 < this.XPIProvider.uninstallAddon()@resource://gre/modules/addons/XPIProvider.jsm:4922 < AddonWrapper.prototype.uninstall()@resource://gre/modules/addons/XPIProvider.jsm:7129 < uninstallHotfix/<()@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Primary%20User/AppData/Roaming/Mozilla/Firefox/Profiles/re0r0aen.SOX%20test/extensions/firefox-hotfix@mozilla.org.xpi!/bootstrap.js:78 < safeCall()@resource://gre/modules/AddonManager.jsm:179 < makeSafe/<()@resource://gre/modules/AddonManager.jsm:195 < Handler.prototype.process()@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:933 < this.PromiseWalker.walkerLoop()@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:812 < this.PromiseWalker.scheduleWalkerLoop/<()@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:746
1462332364537   Services.Metrics.Provider.org.mozilla.addons    WARN    Add-on type without field: greasemonkey-user-script
The connection to wss://wms.zoho.com/pconnect?prd=VO&i=NENVk86NDU3MDg0NDA4Mjk1MDk4MDg5NzozOTAwMjQzOToyMDc6LTE%253D was interrupted while the page was loading. wmsmdsock.html:11:9205
Content Security Policy: Directive 'frame-src' has been deprecated. Please use directive 'child-src' instead. <unknown>
mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create frameworks-90fadde68d68d108f0318274e0f72c8e36717b821c919eb6884c738f6bef8470.js:1:16542
Empty string passed to getElementById(). github-b34f54eabccd0ffa90e322cffdb0db239d492b9a986092f1aa602c5cf84d36b4.js:5:20476
Empty string passed to getElementById(). frameworks-90fadde68d68d108f0318274e0f72c8e36717b821c919eb6884c738f6bef8470.js:10:731
The connection to wss://wms.zoho.com/pconnect?prd=VO&i=NENVk86NDU3MDg0NDA4Mjk1MDk4MDg5NzozOTAwMjQzOToyMDc6LTE%253D was interrupted while the page was loading. wmsmdsock.html:11:9205

FYI, the zoho entries relate to my web email account.

fixer1234 commented 8 years ago

@shu8: BTW, this is probably what you were referring to regarding the issue with some image links in comments showing as a box with an icon. The examples were cases where the link isn't to an actual image, with an image file extension in the link, but to an imgur page that resembles a slideshow, and the image is displayed in that. Example: 2nd pablosan comment on How do I create an Outlook rule for moving all messages flagged on a particular day? contains imgur.com/kRhgdQq.

shu8 commented 8 years ago

@fixer1234 thanks for the example -- that issue will be fixed in v1.0.4.

Also, could you please screenshot what you see when you click the SBS icon? From what I understand, it is doing something, just not what it should...

I think I may be on to something, so this might fix it! Thanks for your patience! :)

fixer1234 commented 8 years ago

@shu8 A couple of interesting developments that might shed some light on something.

First, as noted in my previous comment, the kbd feature wasn't showing. I haven't changed anything, but now it's there. That seems to point to some external code and either it, or access to it, has changed independent of what is in the SOX script.

Interesting discover on SBS. Here is an image of the feature activated:

capture1

Notice that the edit window is more or less centered in the window and the preview window is below it, on the right. However, when I actually use the Find and Replace feature, SBS displays correctly:

capture2

If I click on Find and Replace again to toggle it off, SBS returns to the view in the first image.

On my other computer, which is still running an earlier version of 1.0.4 DEV, the SBS button is there, but Find and Replace/AutoCorrect and KBD don't appear. On that one, SBS works correctly. So it looks like some kind of conflict between SBS and the Find&Replace modules.

Actually, it may not be that it's centered, just that it is being positioned to the right of the Find and Replace/AutoCorrect buttons instead of below them. When Find and Correct is activated, it gets correctly positioned above the edit window.

While I was at it, I retested the access token on SO. The link in the SOX configuration menu is recognized as a link (the cursor changes), but clicking on it still produces no action.

shu8 commented 8 years ago

@fixer1234 aha! Thanks a lot!! I think I've got it!! :D

I'm going to try fix this, but I've got a pretty busy week ahead of me, so it might not be until next weekend when I get back to you :/

sorry!

shu8 commented 8 years ago

@fixer1234 I've made a few changes that should fix all your issues now! :)

Please install this version.

The access token issue, however, remains. I can reproduce it on Firefox but am unable to solve it right now :(

That said, @enki-code and I have been refactoring the script heavily, and we will be changing how the access tokens work in the next version. Till then, I hope your other issues have been fixed, and thanks for staying with us all this time!

Please confirm whether these issues are fixed for you:

Thanks

fixer1234 commented 8 years ago

@shu8: Quick test results:

SBS: works properly with Find/Replace not selected. However, when Find/Replace is selected, the edit window remains in the proper position and the preview window is on the right, but the preview window drops below the edit window:

sbs with find replace

KBD/List: notice in the image that these buttons still don't appear.

EDIT: I closed the question tab and re-selected the question from the main page. This time the KBD/List buttons appeared. So the problem of certain features being intermittent is still there.

I rechecked another feature with this issue: displaying edit comment on hover. One time out of five tries on a random edit example, it displayed the comment. On the other tries, it displayed just the date/time of the edit in the pop-up window. I did a little experimenting and I may have found something, but it's too unreliable to know for sure. If the person editing doesn't leave a comment, the system adds a generic one, like "added nn characters in body". Those system-created comments seems to show much less reliably than comments created by the user. Without extensive testing, though, it's hard to tell if that's just coincidence. In no case is comment display 100%.

Images in comments: working. Image files display, non-images show the link.

link from web input: Looks like you have a new UI. Both browse and web allow selection or entry of file/URL, but neither insert button works.

So progress and partial success, but no cigar, yet.

shu8 commented 8 years ago

@fixer1234 sorry about that!

Please install this updated version

shu8 commented 8 years ago

@fixer1234 regarding the edit comment. could you try pressing Ctrl + Shift + Q and then clicking the Network panel, and then trying to hover over the date?

I have a feeling you're being throttled by the API; when it doesn't work, a network request should appear in the Network tab, and it should be red on the left if it didn't work. Can you screenshot it if it is red?

thanks

BTW, if you're free for 5/10 mins, you can join us in our Gitter chat room: https://gitter.im/soscripted/sox, you can login with your GH account :)

fixer1234 commented 8 years ago

@shu8: Retest:

SBS: Working!

KBD/List: Looks like it's working (success on several random questions)!

Image UI: Working but needs a minor fix. There needs to be at least a space between body text and the image link so that the link isn't interpreted as part of a word. As a test, I just typed along and then inserted an image. It didn't appear in the preview until I added separation. Suggest starting the inserted image link string with a space to ensure that it works.

Edit comment on hover: Let me preface this with the fact that I'm colorblind, so I'm just guessing at "red". I picked a random question with an edit, and the hover produced only a date/time in the pop-up. This happened to be one with a system comment ("added nn characters to body"), rather than a user comment, so at least my observation seems to be holding.

I did the ctrl-shift-Q and then reloaded the page, which produced some output, including this:

api

However, hovering on the edit link reproduced the date/time-only pop-up, but no new entries in that console.

So you've got a couple of items to work on for the next release (and I'll be happy to run more tests if it will help). In the meantime, you've earned the cigar.

shu8 commented 8 years ago

@fixer1234 thanks; will fix the image thing. it will probably be in the refactored version, because it updates using a StackExchange function that currently only works in Chrome; it should work in the refactored version

I'll look into the comment thing a bit more and get back to you

thanks

shu8 commented 8 years ago

@fixer1234 btw, if you come across any more posts where it doesn't work, please could you post the link here? It would help determine what the cause is :)

fixer1234 commented 8 years ago

@shu8 a little more anecdotal feedback:

Edit comments on hover: Based on dozens of checks, whether the pop-up displays the edit comment or just the date/time, or the predominance of which one it displays on repeat hovers, does not depend on: whether the edit is to a question or answer, the recency of the edit (seconds vs. days), or whether it is a system comment vs. user comment. Previous observations were just coincidental. Hovering trials seconds apart will display the comment one time and date/time the next.

Another random test on an edit that repeatedly popped-up just date/time: I did ctrl-shift-Q and reloaded the page. The console detail showed the element loading activity but there was no red. I retested hovering on the edit link many times. A couple of times it displayed the comment (it was a user comment). None of the hovering triggered additional activity in the console. So if you still think this is throttling, this procedure doesn't capture it.

Title edits: Intermittent performance. Came across a random title edit in the review queue that initially displayed deletions and additions mixed. I reloaded the page several times and then it started displaying correctly.

Just came across another one in the review queue: http://superuser.com/review/suggested-edits/533378. I reloaded the page three times and the title continued to display incorrectly. Actually, that one was either a spam edit or a fake edit for audit purposes, so I wouldn't put much credence in this example.

Fix topbar position: I forget whether this was one slated for fixing later or you thought it was already fixed. If I select historical comments from my profile page, the thread gets displayed with the selected comment at the top of the page. Several lines of the comment end up hidden behind the topbar rather than being displayed below the topbar. Clicking on question or answer posts typically don't end up partially hidden (not clear whether this is because the issue is fixed for those or there is just blank space at the top of those posts so the content ends up below the topbar).

Edit window enhancements (SBS, KBD/List, Find&Replace|AutoCorrect): these don't appear when editing a post in a review queue (tested in Suggested Edit and LQ Post review queues).

One other item I'll alert you to, although it may have nothing to do with SOX: on the main page, the number of new, unread posts is normally displayed at the top of the page and in the tab text. It has suddenly intermittently stopped displaying this. Around the same time I loaded the most recent SOX, the system upgraded Firefox from V45 to V46, which turned out to conflict with Oxygen themes on the system. I had to uninstall it and manually install V45 ESR from a Mozilla tarball. So it's back to the Firefox version that was previously working (except for the ESR, which does have a few minor differences), and the same suite of add-ons. The issue could well relate to Firefox rather than SOX, and I'm doing some testing, but I thought I'd mention it in case there's anything in SOX that might potentially cause that.

The count wasn't displaying, so I disabled SOX as a test. The count is displaying again. Could be just coincidence, but I'll keep testing.

shu8 commented 8 years ago

@fixer1234

I don't think SOX should have an effect on the tab text... there's nothing in the code that touches it! I hope it was a coincidence, because that would be very strange if SOX was causing it! :/

fixer1234 commented 8 years ago

@shu8

All of this first group failed 5 out of 5 times in the first test. The results of the second test are coded in parentheses after each link (see coding explanation on the next set):

[Android virtual router](http://superuser.com/q/856197/364367)  (2D, 3C)
[How do I open / extract files from a .b1 archive?](http://superuser.com/a/708725/364367) (failed 5/5 2nd time also)
[AHK won't start Vagrant/Cmder on boot/reload?](http://superuser.com/q/1076955/364367) (failed 5/5 2nd time also)
[Is it worth buying a SSD disk for a motherboard that only supports SATA I?](http://superuser.com/q/570409/364367) (3D, 2C)
[Windows 10 Keyboard Repeat Rate/Delay Keeps Changing](http://superuser.com/a/1077242/364367) (failed 5/5 2nd time also)
[Change Windows 10 Start Menu Icon](http://superuser.com/q/1077245/364367) (failed 5/5 2nd time also)
[Catch cmd window | Can I let it write to file by std?](http://superuser.com/q/1077229/364367) (failed 5/5 2nd time also)

This next group had some number of successes on the first test. The coding after the link is the replications of either comment or date/time. So on the first test, the first example displayed date/time on the first try, then the comment on three successive tries, then the date/time on the last try. Results of the second test are shown in parentheses after the first results.

[Time machine backup on S3](http://superuser.com/a/1061900/364367) 1D, 3C, 1D; (2C, 3D)
[KVM VM not visible/pingable from LAN](http://superuser.com/q/1077227/364367) 4D, 1C; (failed 5/5 on 2nd test)
[Sum numbers in filenames in a directory using command line](http://superuser.com/a/1077233/364367) 2D, 1C, 1D, 1C; (1C, 4D)
[Setting up a SSL server](http://superuser.com/q/1076741/364367) 1D, 2C, 1D, 1C; (failed 5/5 on 2nd test)
[CMD window will not close if folder is closed during execution of bat file](http://superuser.com/a/1077189/364367) 1D, 4C; (1D, 4C)
[Struggling with my Sony bluetooth headset dr-btn200 Windows 8.1](http://superuser.com/a/1077149/364367) 1C, 4D; (5C)

I couldn't find any obvious characteristic differentiating the problem posts, but the results aren't completely random, so there's probably some underlying characteristic. The majority of the first group had the same results on retest, and several in the second group had pretty close retest results. The script always retrieves something, but not always the comment. Could it be a timing thing, where both the date/time and the comment are part of the value being populated or retrieved, and the speed of that (driven by other things), determines which piece gets displayed?

fixer1234 commented 8 years ago

Documenting a strange experience in case it sheds light on anything. I did an edit on this answer: View menu bar & bookmarks toolbar in Firefox 4 full-screen mode?. Here is a screenshot of the edit screen:

su edit screenshot

Normally, the edit screen is at the top of the page. Here, the edit window is positioned in front of a collection of thread elements: previous edit comment, question, and the answer being edited (which are all from different places).

Also, the SOX edit enhancements didn't all appear. Initially, either KBD/List or SBS was missing (I forget which). I reloaded the page and both went missing.

This is the first time either form of corruption appeared.

shu8 commented 8 years ago

@fixer1234 please install this modified version of SOX (making sure it replaces the current version!) and go on any question page.

It should now log quite a bit to the console -- please could you copy and paste the entire console log?

Also, sorry but what's wrong in that screenshot? I don't understand...

And I will add the edit stuff to edits in the next version :)

fixer1234 commented 8 years ago

@shu8 Will do. Just open the page and copy the log, or attempt some of the problem operations and then copy the log? You're referring to ctrl-shift-J? Use the default selections on the tabs as far as what to log?

Explanation of the screenshot:

This was an odd-ball occurrence. Nothing similar happened before or since, so it may be impossible to replicate. However, I thought the constellation of symptoms might provide a clue to what might be going on behind the scenes contributing to other odd symptoms.

shu8 commented 8 years ago

@fixer1234 sorry should have clarified.. yes ctrl+shift+j and could you copy it when you come across a post where the edit comment doesn't show up please.

and about the edit thing: it seems like you held down CTRL when clicking edit -- doing so opens it in a new tab and shows you the UI that you would have without having the edit privilege at 2k.

fixer1234 commented 8 years ago

@shu8 Just as a test, I found a random post where the edit comment didn't appear. I cleared the console, reloaded the page, then hovered on the edit history link several times. The first two times displayed the date/time. Third time displayed the comment. None of the hovering added any content to the console. Here's a screenshot:

su screenshot temp

Let me know if this is capturing what you're looking for and I'll replicate it with other posts.

Re: weird edit window -- There's no way to know for sure that I didn't press Ctrl, but that does reproduce the layout.

Update in case it's useful: I left the console open while I was on this tab writing this comment. A bunch of additional console messages were collected, including one discussing blocking a github resource. Not sure if the additional messages refer to refresh activity on the original page (still open), or my activity on this tab. New screenshot:

su screenshot temp

fixer1234 commented 8 years ago

@shu8 Another quick update. The "Show comment score" previously worked but appears to not work any more (I'm guessing since this test release).

Let me know if the edit comment console screenshots are capturing what you were looking for, and whether to do more.

shu8 commented 8 years ago

@fixer1234 ok, so it seems the edit comment issue is a timing issue (what a surprise :P), because the request to get the comment is going through, but it's not being applied to the tooltip every time.

this has been fixed in the refactored version, and I'll ping you in a few days (hopefully!) when that version is completely finished. We're going to try our best to make sure everything is working in Chrome and on Firefox (where most of our issues unfortunately come from :disappointed:).

The Show Comment Score has also been modified in the refactored version, so hopefully that will work as well.

Thanks for your help and patience. I hope the refactored version does work for you :)

shu8 commented 8 years ago

@fixer1234 We have finally released v2.0.0 just now. I'm very sorry for the long wait, but we have both had a very busy past month or two and haven't had much time to do anything on SOX.

Please could you install this new version. I hope it works well for you! :)

Thanks again for sticking with us through all this! :smile: