sosedoff / pgweb

Cross-platform client for PostgreSQL databases
https://sosedoff.github.io/pgweb
MIT License
8.63k stars 732 forks source link

Issue with building assets #284

Closed PrincipalsOffice closed 7 years ago

PrincipalsOffice commented 7 years ago

After I ran make setup, I tried to make a few small changes in app.js and index.html under static/ and built them with make dev. However the changes won't show when I ran ./pgweb. Did I missed any steps?

sosedoff commented 7 years ago

Hm, that should be the only step needed for the local dev. Did you try flushing your browser cache? Also, how did you setup the project?

PrincipalsOffice commented 7 years ago

I tried to ran it on Safari instead of Chrome and still can't see any changes. I cloned the repo under $GOPATH/src/, and git diff shows that pkg/data/bindata.go is modified.

sosedoff commented 7 years ago

Ah you probably cloned it under your own namespace in $GOPATH/src, you'll need to clone it as $GOPATH/src/github.com/sosedoff/pgweb so that all package references could stay the same.

PrincipalsOffice commented 7 years ago

Thanks!