password with '#' in url doesnt work

sosedoff / pgweb

Cross-platform client for PostgreSQL databases

https://sosedoff.github.io/pgweb

MIT License

8.63k stars 732 forks source link

password with '#' in url doesnt work #349

Closed MstWntd closed 6 years ago

MstWntd commented 6 years ago

Issue: using '#' in the password field of the URL causes pgweb to not connect. '#' works when used in the "standard" connection method.

Bad Example: postgres://pguser:pgpass###@localhost:5433/mydb?sslmode=disable <-- this causes pgweb to get confused as to where the host/port is in the url

Good Example: postgres://pguser:pgpass@localhost:5433/mydb?sslmode=disable <--- this works

Pgweb v0.9.11 (git: c32784e8aebec35c1f68e11bc004f45dedbda283)

sosedoff commented 6 years ago

Ah, the # sign must be escaped for this to work, ie postgresql://user:%23password%23@hostname/database

MstWntd commented 6 years ago

Yup that worked!.. btw you have amazing project here and i really appreciate it!

sosedoff commented 6 years ago

👍