sosedoff / pgweb

Cross-platform client for PostgreSQL databases
https://sosedoff.github.io/pgweb
MIT License
8.55k stars 723 forks source link

Add bookmark options to load username/password from env vars #638

Closed jenbroek closed 1 year ago

jenbroek commented 1 year ago

We keep our configuration for pgweb in a private Git repository. Currently we still have to input the username and password every time, but it would be nice to refer to an environment variable in the bookmarks. That'll allow us to have the 'click-and-go' functionality without the security implications of keeping passwords stored in the repository itself. Using SSH keys is unfortunately not an option.

sosedoff commented 1 year ago

Is https://github.com/AGWA/git-crypt not an option? You can securely store the encrypted data right in your repo

jenbroek commented 1 year ago

Thanks for the quick reply. git-crypt isn't suitable for us I'm afraid; we'd like to use existing Kubernetes secrets to specify username/password. I opened this PR in case this might be of value to you or other users of pgweb, but I also understand this is a very specific situation 😅

sosedoff commented 1 year ago

Thank you!

jenbroek commented 1 year ago

Likewise, and thanks for the great tool!

sosedoff commented 1 year ago

Would you mind dropping me an email with some info on how you run pgweb in your org? This helps me plan for new features/improve things etc.