search

sosedoff / pgweb

Cross-platform client for PostgreSQL databases
https://sosedoff.github.io/pgweb
MIT License
8.67k stars 742 forks source link

No execution time on `No records found` requests. #755

Open Quake4 opened 1 month ago

Quake4 commented 1 month ago

image

Quake4 commented 1 month ago

It is necessary to show the execution time, why is it hidden? A query that does not return a result is the same query as the others with the result. It is unclear why to hide the execution time.

Quake4 commented 1 month ago

its trivial app.js: buildTable

  if (results.rows.length == 0) {
    $("#results_header").html("");
    $("#results_body").html("<tr><td>No records found</td></tr>");
    $("#result-rows-count").html("");
    $("#results").addClass("empty");
    if (results.stats)
      $("#result-rows-count").html(results.stats.query_duration_ms + " ms");
    return;
  }
sosedoff commented 1 month ago

If it's so trivial, why don't you open up a proper PR with the change you'd like to see?

Quake4 commented 3 weeks ago

https://github.com/sosedoff/pgweb/pull/763

I was answering goblin's stupid questions, and he withdrew himself.