Open pmoravec opened 4 years ago
Unless I'm looking in the wrong place, I think the number of plugins gathering stuff from /var/log/containers has grown in the last four years:
`sos/report/plugins/collectd.py
sos/report/plugins/container_log.py
sos/report/plugins/libvirt.py
sos/report/plugins/openstack_aodh.py
sos/report/plugins/openstack_ceilometer.py
sos/report/plugins/openstack_designate.py
sos/report/plugins/openstack_ironic.py
sos/report/plugins/openstack_manila.py
sos/report/plugins/openstack_nova.py
sos/report/plugins/openstack_placement.py
sos/report/plugins/ovn_host.py
sos/report/plugins/rabbitmq.py
` @pmoravec any further thoughts on how to deal with this? A third idea may be to add a new option for add_copy_spec(..., preferred_plugin=myplugin) where we specify that if there's a list of things to capture, and myplugin is specified there and it's active, the file will not be captured in any other plugin. Does it make sense, or is it over-complicated?
Since adding
container_log
plugin, we do collect:/var/log/containers
(up to some limit etc.) incontainer_log
pluginThis could raise the well known problem like #1596 .
Two approaches possible:
add_copy_spec
code to get over such error as a preventive resolution of future equivalent issues (this is 3rd instance of the same problem I am aware)