sosreport / sos

A unified tool for collecting system logs and other debug information
http://sos.rtfd.org
GNU General Public License v2.0
514 stars 540 forks source link

[container_log] /var/log/containers fragments collected in other plugins #2088

Open pmoravec opened 4 years ago

pmoravec commented 4 years ago

Since adding container_log plugin, we do collect:

This could raise the well known problem like #1596 .

Two approaches possible:

jcastill commented 2 days ago

Unless I'm looking in the wrong place, I think the number of plugins gathering stuff from /var/log/containers has grown in the last four years:

`sos/report/plugins/collectd.py

sos/report/plugins/container_log.py

sos/report/plugins/libvirt.py

sos/report/plugins/openstack_aodh.py

sos/report/plugins/openstack_ceilometer.py

sos/report/plugins/openstack_designate.py

sos/report/plugins/openstack_ironic.py

sos/report/plugins/openstack_manila.py

sos/report/plugins/openstack_nova.py

sos/report/plugins/openstack_placement.py

sos/report/plugins/ovn_host.py

sos/report/plugins/rabbitmq.py

` @pmoravec any further thoughts on how to deal with this? A third idea may be to add a new option for add_copy_spec(..., preferred_plugin=myplugin) where we specify that if there's a list of things to capture, and myplugin is specified there and it's active, the file will not be captured in any other plugin. Does it make sense, or is it over-complicated?