sosreport / sos

A unified tool for collecting system logs and other debug information
http://sos.rtfd.org
GNU General Public License v2.0
507 stars 543 forks source link

[RFE] Add some networking related command outputs #3708

Open jeditransistor opened 1 month ago

jeditransistor commented 1 month ago

NIC related FEC: $ ethtool --show-fec EEE: $ ethtool --show-eee ntuple-filters / Flow director: // Can also use -u $ ethtool --show-ntuple

For supportconfig ONLY: $ ethtool --show-coalesce

XPORT Socket statistics: $ ss -s IPv6 statistics: $ netstat -s -6

jcastill commented 1 month ago

Thank you for opening this RFE! Some notes:

"ethtool --show-eee %(dev)s",

In the networking.py plugin, so I imagine that that one doesn't need any modification.

The last two commands are straightforward to add - we only capture ss -peaonmi at the moment and netstat -s . I'll start with these while we get clarification on the ethtool ones.

pmoravec commented 1 month ago

The commands (with expected device names, I guess):

ethtool --show-fec %(dev)
ethtool --show-ntuple %(dev)
ethtool --show-coalesce %(dev)

they 1) provide some additional information not already collected by other commands? 2) do not load a kernel module for their execution, and they dont start a service? 3) they can't get stuck their own execution neither get stuck some networking devices under some specific situations (cf. e.g. https://github.com/sosreport/sos/blob/main/sos/report/plugins/networking.py#L188-L195)?

thierry-schwertz commented 1 month ago

I am the one that have asked this enhancement through RedHat. 1/ You do not need to add: ethtool --show-coalesce %(dev) This is already collected through ethtool -c %(dev) This request was for supportconfig (SLES) 2/ Yes you are right you need to provides interface name '%(dev)' 3/ Yes, "ethtool --show-fec" - applies to ethernet devices