sosreport / sos

A unified tool for collecting system logs and other debug information
http://sos.rtfd.org
GNU General Public License v2.0
508 stars 544 forks source link

[report] Revert changed formatting of plugin+presets lists #3762

Closed pmoravec closed 1 month ago

pmoravec commented 1 month ago

During conversion to f-strings in #3606, some changes in UI output happen. That makes some output less readable and could break some automated tests anticipating given preset or plugin output strings.

This commit reverts back tto the original output, using f-strings.

Resolves: #3762


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

packit-as-a-service[bot] commented 1 month ago

Congratulations! One of the builds has completed. :champagne:

You can install the built RPMs by following these steps:

Please note that the RPMs should be used only in a testing environment.

pmoravec commented 1 month ago

Changes:

# sos report -l | grep -e qpid -e rasdaemon -e "(version"
sosreport (version 4.7.1)
 rasdaemon            rasdaemon kernel trace event monitor
 qpid                 inactive       Qpid messaging
 qpid_dispatch        inactive       Qpid dispatch router
#

vs.:

# sos report -l | grep -e qpid -e rasdaemon -e "(version"
sos report (version 4.8.0)
rasdaemon            rasdaemon kernel trace event monitor
qpid                 inactive       Qpid messaging
qpid_dispatch        inactive       Qpid dispatch router
# 

and:

# sos report --list-presets | head -n8

sosreport (version 4.7.1)

The following presets are available:

         name: none
  description: Do not load a preset
         note: Use to disable automatically loaded presets
#

vs:

# sos report --list-presets | head -n8

sos report (version 4.8.0)

The following presets are available:

name:           none
description: Do not load a preset
note: Use to disable automatically loaded presets
#

(btw this | head generates "nice" flood of backtraces :) )