Closed pmoravec closed 6 days ago
Trivial reproducer:
echo HTTP_PROXY=http://foouser:barpassword@proxyurl:8080 >> /etc/environment
sos report -o system --batch --build
I am not sure if whole /etc/sysconfig
or /etc/default
needs such scrubbing - various services can define the proxy there so it is imho better to cover all. BUT if either directory is password-less every time, I am happy to remove it from the postproc
.
Congratulations! One of the builds has completed. :champagne:
You can install the built RPMs by following these steps:
sudo yum install -y dnf-plugins-core
on RHEL 8sudo dnf install -y dnf-plugins-core
on Fedoradnf copr enable packit/sosreport-sos-3789
Please note that the RPMs should be used only in a testing environment.
OK, the /etc/sysconfig
or /etc/default
could also collect the env.variables, worth processing them as well.
The pylint failure is solved already but checking out this pr doesn't show the commit, so I think you'll have to resync.
Good point wrt Apt plugin where I in fact copied the RE from - I just updated the PR accordingly.
Obfuscate credentials in env.variable settings for e.g. HTTP_PROXY or similar.
Inspired by: #3788 Resolves: #3789
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines