sosuke-k / hyena

2 stars 0 forks source link

animate hyena saving log on project page #76

Closed sosuke-k closed 9 years ago

sosuke-k commented 9 years ago

Why

How

Animation

sosuke-k commented 9 years ago

@rooa I added the following new files:

but, please skip javascripts folder and stylesheets folder and you still don't have to read the files related to testing (e.g. struct_test.go) because I don't really recognize testing...TT

rooa commented 9 years ago

@sosuke-k thanks, I'll look up the codes but it seem that it takes time for me to finish reading. I'll check it by tmr.

rooa commented 9 years ago

Can 2,0,2,2,2 happen? In this case it should be 2,0,0,0,0 if my understanding is correct.

sosuke-k commented 9 years ago

it should be 2,0,2,2,2 because

sosuke-k commented 9 years ago

In this case there are 5 commits and chrome.json was no changed in 2nd commit. Gyazo

sosuke-k commented 9 years ago

https://github.com/sosuke-k/hyena/pull/76/files#diff-0e7214ef20fcc722f1c5a43fe44d2afdR139 In this line, LineNumberSequence.push({line number}) , but no diff can not run this line. so https://github.com/sosuke-k/hyena/pull/76/files#diff-0e7214ef20fcc722f1c5a43fe44d2afdR164 In this line , I push 0 to regulate LineNumberSequence's length.

rooa commented 9 years ago

So it's a dummy 0 when there's no change in the commit of a file. I see

rooa commented 9 years ago

@sosuke-k lgtm

sosuke-k commented 9 years ago

@rooa I'll merge it.