search

sosy-lab / benchexec

BenchExec: A Framework for Reliable Benchmarking and Resource Measurement
Apache License 2.0
227 stars 192 forks source link

Upgrade to react-router 6 #805

Closed PhilippWendler closed 2 months ago

PhilippWendler commented 2 years ago

We are using react-router 5 in our HTML table, and version 6 has been released. Upgrading needs some work on our side (guide).

We have to replace <Switch> with <Routes> and change a few things inside it, but this seems easy.

More complicated is that we use the useHistory hook to listen on history changes in ReactTable.js, and useHistory is gone now. We might be able to use useLocation or the history package that is used by react-router.

However, we also directly access the browser history in some other components and do window.history.pushState() and window.addEventListener("popstate", ...), and sometimes we also access the history property from react-router, which also seems to be gone. So this also needs changes and we should probably rewrite all this history handling to use the same kind of code based on react-router.

PhilippWendler commented 2 years ago

When changing this we should also check whether this can be used to improve our filter handling, which currently relies on setImmediate (cf. 7ed146159a45d1a737d6b7865dd9122beb2662fe).

s2ahil commented 7 months ago

I am a full-stack web developer I work with react. I want to work on this issue.

PhilippWendler commented 7 months ago

That's great! Have a look at our readme for JS development, and if you have any questions, please ask. Questions that are specific to this issue can be asked here, for other questions please open a new issue or discussion.

s2ahil commented 7 months ago

Im aiming for gsoc 2024 , so can I apply this issue for gsoc If I want to contribute in sosy-lab.

Anujvaid45 commented 7 months ago

Hi @PhilippWendler , I am Anuj, A full stack developer from India. I have understood the issue and would like to work on it

PhilippWendler commented 7 months ago

Hi, any help is welcome!