Deprecate .modulo(), add .smod(), .rem()

sosy-lab / java-smt

JavaSMT - Unified Java API for SMT solvers.

Apache License 2.0

180 stars 46 forks source link

Deprecate .modulo(), add .smod(), .rem() #365

Closed leventeBajczi closed 6 months ago

leventeBajczi commented 6 months ago

As discussed in #360, the .modulo() method on the BitvectorFormulaManager API is misleading, because it creates a {s,u}rem operation. Therefore, we deprecate the method, and add separate .smod() and .rem() methods.

The (now deprecated) .modulo() operation delegates to the .rem() operation.