Added array literal creation to API and implementation

sosy-lab / java-smt

JavaSMT - Unified Java API for SMT solvers.

Apache License 2.0

180 stars 46 forks source link

Added array literal creation to API and implementation #367

Closed leventeBajczi closed 6 months ago

leventeBajczi commented 6 months ago

As mentioned in #360, currently, array literals are not supported by the API. This PR adds two new methods to this end, one without a default value, and one with a default (else) value. I also added some tests to verify that these work normally.

leventeBajczi commented 6 months ago

I can see that the SolverConcurrencyTest seems to be failing. However, I cannot reproduce the problem locally. Can you please take a look?

baierd commented 6 months ago

SolverConcurrencyTest is flaky. If its not reproducable locally or continuously in the CI you may ignore that test class.

leventeBajczi commented 6 months ago

I believe you're right that uninitialized arrays do not make a lot of sense. I also see that for the initialized arrays you merged the modifications to master manually - I'm closing this PR. Thanks for the help!