Closed daniel-raffler closed 2 weeks ago
Thanks for the review! I've opened a new issue about the rotations (https://github.com/sosy-lab/java-smt/issues/397). Once this has been resolved the workaround can be removed here. I've also added some more documentations about getVariableCasts
() and merged the calculation into a single function.
Hello, this MR aims to fix the performance issues described in #371. The problem was not about the conversion operation itself, but about the large number of ProverEnvironments that would be created, one for each test input. We solve this by reusing the same ProverEnvironment for all inputs of the test. This also improves the performance of Z3 for those same tests.
In addition to that the MR includes a number of minor fixes:
FunctionDeclarationKind
gets a new SymbolFP_REM
which was missingBV_SHR
andBV_ROL
,BV_ROLI
,BV_ROR
,BV_RORI
to the BitwuzlaFormulaCreator