search

sot / Quaternion

Quaternion manipulation
https://sot.github.io/Quaternion
BSD 3-Clause "New" or "Revised" License
3 stars 7 forks source link

Vectorize #3

Closed jeanconn closed 4 years ago

jeanconn commented 8 years ago

Should Quaternion be updated to use the vector forms in

https://github.com/sot/mica/blob/master/mica/quaternion.py

?

taldcroft commented 8 years ago

Perhaps, but is there an immediate driver?

jeanconn commented 8 years ago

The immediate driver is that if you are updating Quaternion, the two "branches" are diverging. On Jul 13, 2016 2:07 PM, "Tom Aldcroft" notifications@github.com wrote:

Perhaps, but is there an immediate driver?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sot/Quaternion/issues/3#issuecomment-232438985, or mute the thread https://github.com/notifications/unsubscribe/AAwT1P5DOBZENZC3N1fiRv-X8GxYVceTks5qVSlmgaJpZM4JLsKp .

taldcroft commented 8 years ago

Can you make an actual branch and PR for the vectorized version? I recall having some reservations about the implementation but I don't remember details.

jeanconn commented 8 years ago

The actual branch is still there. I'll take an action to clean it up to largely match mica.quaternion and make a PR.

On Wed, Jul 13, 2016 at 2:22 PM, Tom Aldcroft notifications@github.com wrote:

Can you make an actual branch and PR for the vectorized version? I recall having some reservations about the implementation but I don't remember details.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sot/Quaternion/issues/3#issuecomment-232443239, or mute the thread https://github.com/notifications/unsubscribe/AAwT1Gj4X2jnoYnRLNX-XLcUi9RF0lS8ks5qVSztgaJpZM4JLsKp .

jeanconn commented 4 years ago

Closed by #5