This PR changes the data displayed in the tables in the report. Instead of using a file in SKA/data/acq_stat_report to give the expected number of failures, it now uses the p_acq_model column.
The new info displayed includes the 1-sigma quantiles, instead of the p-values included in the older version.
This PR also:
replaces the links to cgi scripts with links to kadi
decouples the fetching of acq info and writing html
merges the two output JSON files into a single file.
It also includes some changes requested in #6:
get rid of config.Config class
rename config.data_dir to config.output_dir
remove remove_bad_stars option from config
rename -v option to --log-level and remove the close_figures parameter
moved script into its own file inside the scripts directory
=============================================== 2 passed in 17.18s ================================================
(ska3-masters) jeanconn-fido> git rev-parse HEAD
09a3751162708a1f470e5887ccabd256c3401b55
### Functional tests
<!-- Describe and document results of any functional tests, otherwise leave the text below -->
In a dedicated environment, I installed chandra_aca master (required for binomial uncertainty). There, I created and empty `$SKA/data/acq_stat_reports` and copied `/proj/sot/ska/data/acq_stat_reports/acq_fail_fitfile.json` into it (useless but still needed). Then I ran:
[output](https://icxc.cfa.harvard.edu/aspect/test_review_outputs/acq_stat_reports/pr-9/web) (compare to the [output from #6](https://icxc.cfa.harvard.edu/aspect/test_review_outputs/acq_stat_reports/pr-6/web))
Description
This PR changes the data displayed in the tables in the report. Instead of using a file in
SKA/data/acq_stat_report
to give the expected number of failures, it now uses thep_acq_model
column.The new info displayed includes the 1-sigma quantiles, instead of the p-values included in the older version.
This PR also:
It also includes some changes requested in #6:
config.Config
classconfig.data_dir
toconfig.output_dir
remove_bad_stars
option from config-v
option to--log-level
and remove the close_figures parameterInterface impacts
Testing
Unit tests
Independent check of unit tests by Jean
acq_stat_reports/tests/test_utils.py .. [100%]
=============================================== 2 passed in 17.18s ================================================ (ska3-masters) jeanconn-fido> git rev-parse HEAD 09a3751162708a1f470e5887ccabd256c3401b55
acq-stat-reports -v debug --url /aspect/test_review_outputs/acq_stat_reports/pr-9/web acq-stat-reports-toc acq-stat-reports-summary