search

sot / astromon

Astrometric accuracy (celestial location) monitor
0 stars 0 forks source link

Explicitly set CIAO_LD_LIBRARY_PATH #3

Closed jeanconn closed 10 years ago

jeanconn commented 10 years ago

This is a work-around for a SKA vs CIAO CFITSIO library conflict that arises in CIAO 4.6.

jeanconn commented 10 years ago

I don't remember the best perl idioms to even make a string.

taldcroft commented 10 years ago

Did you test this? Probably sufficient to just write a one-off script on the side that just proves that adding this line makes it possible to run something like dmlist file.fits blocks within a perl script. That'll be good enough to merge this.

jeanconn commented 10 years ago

I tested by running both scripts in my dev ska (running get_cat_obs_data.pl with the -force flag) and confirming that without the fix they displayed errors and core dumped and with the fix they .. didn't.

taldcroft commented 10 years ago

OK, good with the testing. You can merge and install.

As for the idiomatic perl, it doesn't matter that much. I would have written it in one line (83 characters), but your 3-line version is fine too.

jeanconn commented 10 years ago

Installed.

On Tue, Dec 17, 2013 at 4:40 PM, Tom Aldcroft notifications@github.comwrote:

OK, good with the testing. You can merge and install.

As for the idiomatic perl, it doesn't matter that much. I would have written it in one line (83 characters), but your 3-line version is fine too.

— Reply to this email directly or view it on GitHubhttps://github.com/sot/astromon/pull/3#issuecomment-30793968 .