Update guide_count for 5.2mag bright limit

sot / chandra_aca

Chandra Aspect Camera Tools

https://sot.github.io/chandra_aca

BSD 2-Clause "Simplified" License

0 stars 0 forks source link

Update guide_count for 5.2mag bright limit #119

Closed jeanconn closed 3 years ago

jeanconn commented 3 years ago

Description

Update guide_count for 5.2mag bright limit

Testing

[x] Passes unit tests on linux
[x] Functional testing - update to unit tests was a functional test

jeanconn commented 3 years ago

Not sure if we want to do something more rigorous at the bright limit but this just treats 5.2 like 5.8 was handled before.

jeanconn commented 3 years ago

I had forgotten that we have code in guide_count here to use a value a bit more than one for some optimization purposes, but don't think it was the right thing for the code Tom has in https://github.com/sot/sparkles/pull/161.

taldcroft commented 3 years ago

.. but don't think it was the right thing for the code Tom has in sot/sparkles#161.

Correct.

taldcroft commented 3 years ago

Not sure if we want to do something more rigorous at the bright limit but this just treats 5.2 like 5.8 was handled before.

This is fine for the scope of this PR. If we later find a need for something better we'll handle that in a new PR.