Fix tests after changes in maude

sot / chandra_aca

Chandra Aspect Camera Tools

https://sot.github.io/chandra_aca

BSD 2-Clause "Simplified" License

0 stars 0 forks source link

Fix tests after changes in maude #122

Closed javierggt closed 2 years ago

javierggt commented 2 years ago

Description

It seems like in the latest maude update, some floating point values changed slightly. This caused chandra_aca tests to fail. This PR changes those tests so floating point values are checked using np.isclose(a, b) instead of a == b.

Testing

[x] Passes unit tests linux (at least one required)
[n/a] Functional testing

Fixes #

jeanconn commented 2 years ago

Are there any downstream issues with these differences from the maude update?

javierggt commented 2 years ago

I don't know for sure, but I doubt it very much. The issue was that the values are not exactly the same, which is not uncommon with floating point types. The question is whether these tests need to be to full precision.

jeanconn commented 2 years ago

Seems reasonable to me too, though I've forgotten what the default isclose tolerances are.

javierggt commented 2 years ago

I forgot about this PR. I just checked that tests pass after @jeanconn and will merge+tag now.