search

sot / chandra_aca

Chandra Aspect Camera Tools
https://sot.github.io/chandra_aca
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

fix in maude_decom.get_aca_packets from blobs #130

Closed javierggt closed 2 years ago

javierggt commented 2 years ago

Description

This is a trivial change in maude_decom.

When calling get_aca_packets using blobs, it currently sets the image function from AOACFCT{slot}, which is the MSID for the image function in the OBC. After this PR, it will set it from {pea_prefix}AIMGF{slot}1.

One reason to keep the OBC value is that it is sampled much more often, but then it does not match the image shown, so this can cause confusion. I do not remember if we explicitly decided to keep that one. If wed wanted that, I still think this is not the place to do it (because this is all about ACA packets).

Another option is to not have a single image function, but include all four instances of IMGFUN found in ACA telemetry.

Interface impacts

None

Testing

Unit tests pass, including a new test that would fail in current master.

Unit tests

Independent check of unit tests by [REVIEWER NAME]

Functional tests

No functional testing.

taldcroft commented 2 years ago

it is sampled much more often

I presume that you mean the OBC AO.. version is sampled every 1.025 sec and the PEA version comes down once per readout image (which could be either 1.025, 2.05, or 4.1 sec). ls that right?

taldcroft commented 2 years ago

The code looks fine, there just needs to be some documentation of testing since I presume the unit tests don't cover this.

javierggt commented 2 years ago

I presume that you mean the OBC AO.. version is sampled every 1.025 sec and the PEA version comes down once per readout image

Yes

I added a test that fails in current master and this PR would fix it. Basically, the decom from VCDU frames takes IMGNUM1 already, and this test just checks the consistency between blobs and frames.