sot / chandra_aca

Chandra Aspect Camera Tools
https://sot.github.io/chandra_aca
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Use ACA drift model from chandra_models JSON file #134

Closed taldcroft closed 1 year ago

taldcroft commented 1 year ago

Description

This updates the ACA drift model module so that it takes the parameters from a JSON file instead of having them hardwired into the code.

By default the parameters are in $SKA/data/chandra_models/chandra_models/aca_drift/aca_drift_model.json. This can be overridden for testing by setting the ACA_DRIFT_MODEL_PATH environment variable.

Interface impacts

No external impacts, but it does require promotion of:

Testing

Unit tests

Put the new drift model file from https://github.com/sot/chandra_models/pull/95 into my Mac $SKA/data/chandra_models repo (as an unversioned file) and ran unit tests successfully. Inserted a temporary print statement to confirm that the expected file was being used.

Independent check of unit tests by Jean

Functional tests

New unit test.

jeanconn commented 1 year ago

Also, I think the updated unit tests are a functional test.

taldcroft commented 1 year ago

@jeanconn - I ran the unit tests for record as now documented.