sot / chandra_aca

Chandra Aspect Camera Tools
https://sot.github.io/chandra_aca
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Modernize #136

Closed taldcroft closed 1 year ago

taldcroft commented 1 year ago

Description

This removes an unnecessary limitation that the body provided to get_planet_chandra_horizons needed to be a planet. In fact any allowed Horizons body name or integer identifier is fine here. The function name is unfortunate since body can be anything now.

I also discovered that the previous CGI web interface is deprecated in favor of a new proper web API interface, so this migrates to that new interface.

For the key functions in the planets module this adds type annotations.

Interface impacts

None except expands the capability of get_planet_chandra_horizons.

Testing

Requires https://github.com/sot/cxotime/pull/31

Unit tests

Independent check of unit tests by Jean

Functional tests

No functional testing.