search

sot / chandra_aca

Chandra Aspect Camera Tools
https://sot.github.io/chandra_aca
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Remove use of astropy override__dir__ #142

Closed javierggt closed 1 year ago

javierggt commented 1 year ago

Description

This PR removes the use of deprecated decorator astropy.utils.compat.misc.override__dir__ and replaces it with the suggestion in the docstring of override__dir__.

which causes the following warning:

WARNING: AstropyDeprecationWarning: http://bugs.python.org/issue12166 is resolved. See docstring for alternatives. [chandra_aca.aca_image]

Interface impacts

None

Testing

Unit tests

Independent check of unit tests by [REVIEWER NAME]

Functional tests

I checked that the deprecation warning is gone in 2023.1rc4:

python -c 'import chandra_aca.aca_image'

I also checked in the command line that IMGCOL0 and IMGROW0 are in __dir__()

taldcroft commented 1 year ago

Looks like you missed the WIP #141. Sorry I didn't get that in shape for review. I think the code is OK, just not done with testing.