search

sot / chandra_aca

Chandra Aspect Camera Tools
https://sot.github.io/chandra_aca
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Use chandra_models_cache for caching not lru_cache #150

Closed taldcroft closed 1 year ago

taldcroft commented 1 year ago

Description

This updates the function to get the acq probability model (from chandra_models) to cache using chandra_models_cache from https://github.com/sot/ska_helpers/pull/36.

Interface impacts

None

Testing

Unit tests

In a dev Ska environment with https://github.com/sot/ska_helpers/pull/36 installed.

Independent check of unit tests by Jean

Functional tests

No functional testing.

jeanconn commented 1 year ago

I think this could still get in the release, but it looks like it needs help past merge conflict.

jeanconn commented 1 year ago

Maybe in poor taste but I did a rebase and resolved conflicts manually and then force pushed.

javierggt commented 1 year ago

That's fine by me. Are we waiting for Tom to merge?

jeanconn commented 1 year ago

I was waiting for Tom to merge but maybe with no specific direction to hold it would be fine to go ahead with this and the proseco one.