search

sot / chandra_aca

Chandra Aspect Camera Tools
https://sot.github.io/chandra_aca
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Add function to get default acq prob model info #151

Closed taldcroft closed 1 year ago

taldcroft commented 1 year ago

Description

This adds a new function to get provenance information about the default acquisition probability model (subject to environment variables). This is intended to be used in proseco to add this info to the star catalogs pickle file.

Interface impacts

Adds new function get_default_acq_prob_model_info.

Testing

Unit tests

In a dev Ska environment with https://github.com/sot/ska_helpers/pull/36 installed.

Independent check of unit tests by Jean

Functional tests

No functional testing. (but there is a new unit test to cover the new functionality)

jeanconn commented 1 year ago

I don't know if it is within scope, but when I was seeing the warnings in starcheck

Model grid-* computed between mag <= 5.0 <= 10.75, clipping input mag(s) outside that range.

I thought it wasn't great that the model wasn't resolved at that point to a full model name.

taldcroft commented 1 year ago

I added a commit to improve the warning when clipping.

jeanconn commented 1 year ago

I only confirmed by inspection that the new clip warning will likely work with https://github.com/sot/starcheck/pull/416/files but will test and update starcheck if it doesn't.

jeanconn commented 1 year ago

I confirmed the warnings filter in starcheck.utils is still fine with this updated clip warning.