Make maude_decom.get_aca_images robust agains missing/repeated frames - Githubissues

sot / chandra_aca

Chandra Aspect Camera Tools

https://sot.github.io/chandra_aca

BSD 2-Clause "Simplified" License

0 stars 0 forks source link

Make maude_decom.get_aca_images robust agains missing/repeated frames #159

Closed javierggt closed 9 months ago

javierggt commented 10 months ago

Description

This PR fixes two issues that were found while reading monitoring data:

maude_decom.get_aca_images crashes if stop is after the last frame available in MAUDE. In this case some maude queries return no data, and the downstream code should not crash.
maude_decom.get_aca_images crashes if there are missing/repeated frames.

A test was added for the case of repeated/missing frames.

Interface impacts

Testing

Unit tests

[ ] No unit tests
[x] Mac
[ ] Linux
[ ] Windows

Independent check of unit tests by Jean

[x] Mac

Functional tests

No functional testing.

jeanconn commented 10 months ago

It looks like @taldcroft's comments are substantive, so feel free to ping me for a new review when those issues are resolved.

taldcroft commented 9 months ago

I'm delegating to @jeanconn's review and bowing out.