sot / chandra_aca

Chandra Aspect Camera Tools
https://sot.github.io/chandra_aca
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Improve accuracy and speed of planet functions #162

Closed taldcroft closed 9 months ago

taldcroft commented 9 months ago

Description

This includes a few improvements / fixes:

Overall the get_planet_barycentric function is about 10-12 times faster for scalar or small-array valued inputs.

The accuracy of Venus planet predictions was improved from about 3-4 arcsec to under 0.2 arcsec relative to JPL Horizons.

Interface impacts

Planet positions will change slightly for the better.

Testing

Unit tests

chandra_aca/tests/test_aca_image.py .............. [ 7%] chandra_aca/tests/test_all.py ........................ [ 19%] chandra_aca/tests/test_attitude.py ............................................................. [ 50%] chandra_aca/tests/test_dark_model.py .... [ 52%] chandra_aca/tests/test_drift.py .......................... [ 65%] chandra_aca/tests/test_maude_decom.py ............... [ 73%] chandra_aca/tests/test_planets.py ............. [ 79%] chandra_aca/tests/test_psf.py ... [ 81%] chandra_aca/tests/test_residuals.py ss... [ 83%] chandra_aca/tests/test_star_probs.py ................................ [100%]

============================================ 195 passed, 2 skipped in 31.86s =============================================


Independent check of unit tests by Javier
- [x] OSX:

### Functional tests
<!-- Describe and document results of any functional tests, otherwise leave the text below -->
See the two new validation notebooks.