search

sot / chandra_aca

Chandra Aspect Camera Tools
https://sot.github.io/chandra_aca
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Add FM centroid function to aca_image #44

Closed taldcroft closed 7 years ago

taldcroft commented 7 years ago

About the pix_zero_loc, the PEA uses edge, so I think it's important to be explicit everywhere about the convention. Even in testing updates to aca_psf_library I got momentarily hung up on this half-pixel offset, which was the initial driver.

jeanconn commented 7 years ago

Regarding pix_zero_loc I'm not sure about the best place to make more notes about that or maybe provide some questions to the user to help answer which one to use. For example, for the aca_psf_library, so as long as the bin setup (in that case, from 3 to 4) matches the pix_zero_loc (center) it is OK. Are there other places to think about this in that code?

taldcroft commented 7 years ago

I think your question is already addressed in https://github.com/sot/aca_psf_library/pull/2. The system for the actual data file is not relevant to the user (of our Python module at least).

jeanconn commented 7 years ago

I don't think sot/aca_psf_library#2 necessarily addresses the question about the best place to put a human-readable note about questions, considerations, and ramifications, but the code helps a little.