decode_power not giving all information

sot / chandra_cmd_states

Interface for creation and maintenance of the Chandra commanded states database.

https://sot.github.io/cmd_states

BSD 3-Clause "New" or "Revised" License

3 stars 1 forks source link

decode_power not giving all information #34

Closed jzuhone closed 6 years ago

jzuhone commented 6 years ago

@jeanconn it appears that when the changes were made to decode_power in PR #31 (resulting in version 3.13) that the state of vid_board and clocking are no longer returned:

decode_power("WSPOW04F3E")

gives

{'ccd_count': 5,
 'ccds': 'I0 I1 I2 I3 S2 ',
 'fep_count': 5,
 'feps': '1 2 3 4 5 '}

similarly,

decode_power('WSPOW00000')

gives

{'ccd_count': 0, 'ccds': '', 'fep_count': 0, 'feps': ''}

But looking at the code, it's not obvious why this should happen.

jzuhone commented 6 years ago

@jeanconn false alarm--sorry, my dumb mistake. I was on the wrong version of cmd_states. Closing this issue.

jeanconn commented 6 years ago

@jzuhone No sweat; part of the problem is that for this old code there isn't great unit test coverage so it isn't easy to verify that something is actually working...