sot / chandra_time

Convert between various time formats relevant to Chandra.
https://sot.github.io/Chandra.Time
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Add compile arg for building on MacOS Catalina / Xcode 11.2 #34

Closed taldcroft closed 4 years ago

taldcroft commented 4 years ago

This is apparently needed to allow building Chandra.Time with the latest OS / tools on MacOS.

This includes and thus supercedes #36.

Testing

Closes #36

taldcroft commented 4 years ago

This passes python setup.py test on all build platforms + Catalina and Mojave.

jeanconn commented 4 years ago

Great. I assume the setuptools_scm is good to go as well. Will this make Chandra.Time 3.20.4 or 3.21 or ?

taldcroft commented 4 years ago

I just checked on the setuptools_scm working (it does) but noticed there is a conflict between the two. So I just rebased this on scm_version and resolved the conflict. So as with the other PRs I have been developing, this will supercede scm_version and close it.

About the version, 3.20.4. I'm working on getting all the skare3 issues in to reflect package updates and version numbers.