Fix the location of the C extension

sot / chandra_time

Convert between various time formats relevant to Chandra.

https://sot.github.io/Chandra.Time

BSD 3-Clause "New" or "Revised" License

4 stars 1 forks source link

Fix the location of the C extension #39

Closed javierggt closed 4 years ago

javierggt commented 4 years ago

Description

After the namespace module changes, it turned out the _axTime3 C extension was being installed in site-packages/Time instead of site-packages/Chandra/Time. This PR fixes that.

Testing

[x] Passes unit tests on MacOS, linux, Windows (at least one required)
[ ] Functional testing (no functional tests were made)

Fixes #

javierggt commented 4 years ago

Please merge sot/skare3/pull/329 before this one

jeanconn commented 4 years ago

Though didn't we also want to do something to move the Cython imports so we wouldn't need Cython in the "run ska_builder.py" environment?

javierggt commented 4 years ago

These changes were made trying to be as close to what was there. I do not understand exactly what you mean by moving the cython imports.

jeanconn commented 4 years ago

I meant https://github.com/sot/skare3/issues/255#issuecomment-573836441 but still doesn't have to be in this PR, I just meant perhaps to do before tagging another Chandra.Time. Or maybe that got moot somewhere along the way.

javierggt commented 4 years ago

I see what you mean, and you are right. It should still be an issue.

taldcroft commented 4 years ago

Is there any reason to not make the little fix suggested in https://github.com/sot/skare3/issues/255#issuecomment-573836441 right now here and in Ska.Numpy? This might avoid having this conversation again in 3 months.

taldcroft commented 4 years ago

See https://github.com/sot/Chandra.Time/pull/40, https://github.com/sot/Ska.Numpy/pull/7