Closed taldcroft closed 4 years ago
OT, but the Cython extension name does not match thing is fixed now upstream, see: https://github.com/cython/cython/issues/2128 and https://github.com/cython/cython/commit/f3d3f82bd98cb4b9f9eef0996f999243f9f776d0.
I assume you made the same tests as in sot/Ska.Numpy/pull/7. If yes, I approve.
Yes, I did that testing for both of the PRs.
Description
This addresses the problem in https://github.com/sot/skare3/issues/255.
Testing
(BTW, I note still getting(fixed upstream in newer Cython version).Warning: Extension name 'Chandra.Time._axTime3' does not match fully qualified name 'Time._axTime3' of 'Chandra/Time/_axTime3.pyx'
Getting version in a cython-free environment
Building / test in ska3
Fixes #255