Change so date like 2020:001 is midnight not noon - Githubissues

sot / chandra_time

Convert between various time formats relevant to Chandra.

https://sot.github.io/Chandra.Time

BSD 3-Clause "New" or "Revised" License

4 stars 1 forks source link

Change so date like 2020:001 is midnight not noon #46

Closed taldcroft closed 4 years ago

taldcroft commented 4 years ago

Description

Based on popular demand, this changes Chandra.Time so that a date like 2020:001 will be taken as 2020:001:00:00:00 not 2020:001:12:00:00.

This adds a new function use_noon_day_start to provide back-compatibility where necessary. Cheta back-end data ingest is one intended use case.

This is likely to break at least a few things, so testing will be critical.

This is targeted for shiny: both the skare3 branch and local branch here called shiny.

Testing

[x] Passes unit tests on MacOS
[N/A] Integration testing will be done as part of skare3 / shiny testing

Closes #5 (from 2012!)

taldcroft commented 4 years ago

FYI this will be tagged as version 4.0, giving a major version bump for the back-incompatible change.