search

sot / cheta

Cheta Telemetry Archive
https://sot.github.io/eng_archive
BSD 3-Clause "New" or "Revised" License
3 stars 4 forks source link

Improve MSID representation #223

Closed taldcroft closed 2 years ago

taldcroft commented 2 years ago

Description

The actual MSID name was missing from the MSID object repr.

Testing

jeanconn commented 2 years ago

This seems fine. Looking around for uses of repr in code, this seems benign

https://github.com/sot/eng_archive/blob/449b7681dd2bcfb6007e7db8bd7171493bbc14e9/Ska/engarchive/tests/test_fetch_regr.py#L101

(not entirely clear if bads is an msid there anyway) and this also seems benign

https://github.com/sot/xija/blob/1d53f071136313b87c914b07217056943394b389/xija/component/heat.py#L1276

(not clear if state_val is an msid at that point either).

taldcroft commented 2 years ago

Both of those are not MSID objects => no impact.