search

sot / correct_periscope_drift

0 stars 0 forks source link

Collection of "second draft" fixes for tool and docs #11

Closed jeanconn closed 8 years ago

jeanconn commented 8 years ago

Collection of "second draft" fixes for tool and docs

taldcroft commented 8 years ago

BTW, github/markdown checkboxes is an option to consider in the future for a bunch of minor fixes to a project.

jeanconn commented 8 years ago

​Though I'd still need a PR right? I feel like these just go in master but it is easier to examine the changes if I make a new PR with progress.​

On Wed, Sep 14, 2016 at 1:42 PM, Tom Aldcroft notifications@github.com wrote:

BTW, github/markdown checkboxes is an option to consider in the future for a bunch of minor fixes to a project.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sot/correct_periscope_drift/pull/11#issuecomment-247095672, or mute the thread https://github.com/notifications/unsubscribe-auth/AAwT1JdlgwXIC-lsuk24jV09ciNUSdG_ks5qqDHqgaJpZM4J8_7U .

taldcroft commented 8 years ago

Yes, you make exactly this PR, but with a description at the top that has a checkbox for each change.

Not a big deal and opening a new issue for each change N works well.

taldcroft commented 8 years ago

As soon as my comments on the readme file have been addressed you should contact Daniel Wang.

jeanconn commented 8 years ago

I think I've addressed you comments (largely in this PR) but I'm not sure if I missed anything you mentioned in person during the annealing activity. I'm going to merge this and proceed, but will continue working on testing.